Cleanup WorldEdit-CLI data version systems #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
me4502
commented
Jun 25, 2023
•
me4502
commented
- This PR does a few minor cleanups around the data system, and makes it better at handling reoccurring loads of data without duplicates in the registries.
- Intended as a first step to making WE-CLI download this data
me4502
force-pushed
the
chore/cli-data-version-cleanup
branch
from
81fc648
to
d363848
Compare
me4502
force-pushed
the
chore/cli-data-version-cleanup
branch
from
51447f4
to
435ea50
Compare
me4502
force-pushed
the
chore/cli-data-version-cleanup
branch
from
435ea50
to
66ed93a
Compare
Sketchy implementation atm, better will follow - this "works" as-is without any special handling of missing versions. Intention is to get the "next closest version" when it's not available
me4502
force-pushed
the
chore/cli-data-version-cleanup
branch
from
b3d001c
to
898b600
Compare
octylFractal
requested changes
Apr 2, 2024
worldedit-cli/src/main/java/com/sk89q/worldedit/cli/data/DataFile.java
Outdated
Show resolved
Hide resolved
worldedit-cli/src/main/java/com/sk89q/worldedit/cli/data/FileRegistries.java
Outdated
Show resolved
Hide resolved
worldedit-cli/src/main/java/com/sk89q/worldedit/cli/data/FileRegistries.java
Outdated
Show resolved
Hide resolved
octylFractal
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.