Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors break inconsistently #77

Open
thatONEjustin opened this issue Oct 7, 2024 · 2 comments
Open

Colors break inconsistently #77

thatONEjustin opened this issue Oct 7, 2024 · 2 comments
Labels
feature-request Feature Requests

Comments

@thatONEjustin
Copy link

thatONEjustin commented Oct 7, 2024

examples:

2024-10-07_12:38:17

example also has arrow Ligature breaking (using WezTerm + FiraCode enabled, works everywhere else, even within file at certain points)
2024-10-07_12:42:23

LazyVim config
2024-10-07_12:41:22

@EmranMR
Copy link
Owner

EmranMR commented Oct 7, 2024

Hi @thatONEjustin I just ran a test on your snippets, and everything seem to be working fine, apart from the @asset directive. Is the @asset coming from a third party framework?

If so, please drop me the link to the framework/library, and I will add support for directives for that library.

However, regardless, the whole point of tree-sitter is graceful failure without breakage where possible. As you can see things are still highlighted correctly, even though the parser does not recognise @asset in my editor.

example also has arrow Ligature breaking (using WezTerm + FiraCode enabled, works everywhere else, even within file at certain points)

tree-sitter has nothing to do with the ligatures, and if the ligatures work on other files or otherwise, it might be due to the issues with the highlighting.

Although these snippets came out fine, there might be an issue somewhere else in the file. Not sure unless I can run test on the whole file. See if you can pinpoint at what point the breakage start. Or if everything works fine when using first party directives only.

image

@thatONEjustin
Copy link
Author

thatONEjustin commented Oct 7, 2024

oh great call the blade implementation is coming from the roots/sage WordPress theme

https://roots.io/sage/

EDIT: there's another plugin that adds additional directives: https://github.com/Log1x/sage-directives

@EmranMR EmranMR added the feature-request Feature Requests label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature Requests
Projects
None yet
Development

No branches or pull requests

2 participants