Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring some controls #44

Open
edan-bainglass opened this issue Jul 18, 2023 · 0 comments
Open

Refactoring some controls #44

edan-bainglass opened this issue Jul 18, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@edan-bainglass
Copy link
Collaborator

It is often that controls come in packs, e.g. axes limits, down-selection, etc. Even in the case of a single control, it is not only adding the control to the view, but also "plugging" it in to the plot presenter, i.e. observing/reacting to it. It would greatly reduce burden on current classes if these single/grouped control features could be refactored into Control(s) classes to be dropped in where desired.

Initial attempts to implement these ran into the infamous inheritance diamond problem. The Mixin pattern was also considered but not yet attempted. More thought is needed on this matter.

Input welcomed!

@edan-bainglass edan-bainglass added the enhancement New feature or request label Jul 18, 2023
@edan-bainglass edan-bainglass self-assigned this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant