Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Prepare method of TPyLocalEnvironment allows invalid Distributions #17

Open
peardox opened this issue Sep 11, 2022 · 1 comment
Open
Assignees
Labels
question Further information is requested

Comments

@peardox
Copy link
Contributor

peardox commented Sep 11, 2022

The JSON file provided as FilePath may contain invalid entries that don't point to files and directories on the target system.

When processing the individual entries Prepare's Anonymous method should verify the existance of the files and directories before adding the Distribution.

It is also possible to add the same entry multiple times resulting in more than one valid entry for a Distribution

@lmbelo
Copy link
Member

lmbelo commented Sep 11, 2022

Distributions can be set statically. The environment where it was set might not contain the same settings as the target environment. We can't validate it on setting up step. However, we can validate it as we try to activate the environment.

@lmbelo lmbelo self-assigned this Sep 11, 2022
@lmbelo lmbelo added the question Further information is requested label Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants