Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update focus JS #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update focus JS #26

wants to merge 3 commits into from

Conversation

Anubarak
Copy link

Do not trigger the close handler if the event current target is something different than the actual target to prevent closing on click on something in the focus.

Didn't want to install gulp, I only use webpack with yarn or npm so I didn't create a build for it

disable close on click
@Cam
Copy link
Member

Cam commented Jan 13, 2021

@Anubarak looks good.

I'm considering removing build packs anyway. There's no need for them for a simple project like this. I'll start that process then merge this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants