Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy complains of redundant deref #184

Open
jayvdb opened this issue Jan 31, 2024 · 0 comments
Open

clippy complains of redundant deref #184

jayvdb opened this issue Jan 31, 2024 · 0 comments

Comments

@jayvdb
Copy link
Collaborator

jayvdb commented Jan 31, 2024

warning: call to `.deref()` on a reference in this situation does nothing
   --> /home/jayvdb/rust/butane/butane_core/src/db/sqlite.rs:490:52
    |
490 |             return Err(Error::IncompatibleCustomT(v.deref().clone(), BACKEND_NAME))
    |                                                    ^^^^^^^^ help: remove this redundant call
    |
    = note: the type `SqlTypeCustom` does not implement `Deref`, so calling `deref` on `&SqlTypeCustom` copies the reference, which does not do anything and can be removed
    = note: `#[warn(noop_method_call)]` on by default

Not sure if we might want to implement Deref. Probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant