Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include robot assembly #267

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Include robot assembly #267

merged 2 commits into from
Sep 16, 2024

Conversation

JesusSilvaUtrera
Copy link
Contributor

@JesusSilvaUtrera JesusSilvaUtrera commented Sep 13, 2024

🎉 New feature

Closes #237

Summary

I have added to the README.md of the andino_hardware package the assembly steps.

Test it

Just check the README.md

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: I will open the PR as a draft first to discuss what things to add, or whether the format is okay or not.

@JesusSilvaUtrera
Copy link
Contributor Author

@francocipollone @jballoffet new PR to ease the review of the assembly process, PTAL so we can merge this part.

Signed-off-by: JesusSilvaUtrera <[email protected]>
Copy link
Member

@jballoffet jballoffet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank @JesusSilvaUtrera!

@jballoffet jballoffet merged commit 9f027b8 into Ekumen-OS:humble Sep 16, 2024
4 checks passed
jballoffet added a commit that referenced this pull request Sep 17, 2024
* Updates CHANGELOG.

Signed-off-by: Franco Cipollone <[email protected]>

* 0.2.0

* Updates README.md

Signed-off-by: Franco Cipollone <[email protected]>

* Adds reference to andino_rmf repo (#263)

Signed-off-by: Franco Cipollone <[email protected]>

* Include robot assembly (#267)

* Added all necessary changes to the README

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Removed a blank line

Signed-off-by: JesusSilvaUtrera <[email protected]>

---------

Signed-off-by: JesusSilvaUtrera <[email protected]>

* Remove andino_gz_classic and andino_apps references (#259)

Signed-off-by: JesusSilvaUtrera <[email protected]>

---------

Signed-off-by: Franco Cipollone <[email protected]>
Signed-off-by: JesusSilvaUtrera <[email protected]>
Co-authored-by: Franco Cipollone <[email protected]>
Co-authored-by: Franco Cipollone <[email protected]>
Co-authored-by: Jesús Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Include assembly process
2 participants