Include robot assembly #238

JesusSilvaUtrera · 2024-04-26T12:48:40Z

🎉 New feature

Closes #237

Summary

I have added to the README.md of the andino_hardware package the assembly steps.

Test it

Just check the README.md

Checklist

Signed all commits for DCO
Added tests
Added example and/or tutorial
Updated documentation (as needed)

Note to maintainers: I will open the PR as a draft first to discuss what things to add, or whether the format is okay or not.

francocipollone

Looking good! Just dropped some comments 🚀

andino_hardware/README.md

francocipollone · 2024-04-30T19:11:43Z

andino_hardware/README.md

@@ -21,36 +19,37 @@ This package aims to provide the necessary information to the correct assembly o

 ## Assembly Process

-Following you can see a photo with all the parts:
+The steps to reproduce the mounting of the Andino are:


Being super obnoxious (nit ^10) 🤓 : I guess we can remove this line as the section and steps are self explanatory

francocipollone

Just noticed the following: the size of the images.

In order to avoid having a heavyweight repo, could you try to compress the images even more? I think that having images up to 1mb would be enough. (in case we notice the quality is too bad we could be stretch up to 2mb).

francocipollone · 2024-05-01T21:17:37Z

andino_hardware/docs/parts.png

Btw I love the numbers for guiding.

Yeah I thought about it this morning too, I will do that tomorrow, let's see if the image with the numbers can be compressed uo to 2 mb and look good, with the others there shouldn't be any problem.

By the way, do you know which tool was used for the connections diagram? I was thinking of using GIMP to create it but just for curiosity.

Super handmade. Check this: https://docs.google.com/drawings/d/1wummJPj3EJHSpB-iakCe97DVVQHOPI6oLSaNHQ7MesI/edit

Great, thanks!

Signed-off-by: JesusSilvaUtrera <[email protected]>

… the parts Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: JesusSilvaUtrera <[email protected]>

…rera/andino into jesus/#237_assembly_process

Signed-off-by: JesusSilvaUtrera <[email protected]>

francocipollone · 2024-06-09T23:27:57Z

Just passing by, I haven't reviewed as it is a draft, let me know otherwise 👍

Signed-off-by: JesusSilvaUtrera <[email protected]>

…ly_process

* andino_apps package created and andino_navigation package updated Signed-off-by: JesusSilvaUtrera <[email protected]> * Minor changes from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Update andino_navigation README with changes from PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Add andino_apps package to ci.yaml Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed minor issues from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Added 'andino_apps' to the general README Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]>

* Changes to add IMU to andino firmware Signed-off-by: Gonzalo de Pedro <[email protected]> * Address comments Signed-off-by: Javier Balloffet <[email protected]> --------- Signed-off-by: Gonzalo de Pedro <[email protected]> Signed-off-by: Javier Balloffet <[email protected]> Co-authored-by: Gonzalo de Pedro <[email protected]> Co-authored-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]> Co-authored-by: Lola Segura <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Sakura286 <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

* Improves andino_navigation package. (#224) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Add basic Platform IO instructions (#229) Signed-off-by: Gary Servin <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Modify Shell class API to allow dependency injection (#221) Signed-off-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed wheel diameter in URDF (#93) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added YAML file for default camera intrinsics (#169) Signed-off-by: JesusSilvaUtrera <[email protected]> * Adds references to o3de and isaac_sim simulations. (#232) Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> * Added README for andino_bringup (#233) Signed-off-by: JesusSilvaUtrera <[email protected]> * Added binaries installation docs (#234) Signed-off-by: JesusSilvaUtrera <[email protected]> * andino_apps package created and andino_navigation package updated (#235) * andino_apps package created and andino_navigation package updated Signed-off-by: JesusSilvaUtrera <[email protected]> * Minor changes from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Update andino_navigation README with changes from PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Add andino_apps package to ci.yaml Signed-off-by: JesusSilvaUtrera <[email protected]> * Fixed minor issues from the PR Signed-off-by: JesusSilvaUtrera <[email protected]> * Added 'andino_apps' to the general README Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: JesusSilvaUtrera <[email protected]> * Minimal change to test launch file Signed-off-by: JesusSilvaUtrera <[email protected]> * Added webcam.yaml file and intrinsics are now publishing Signed-off-by: JesusSilvaUtrera <[email protected]> * Added raspicam.yaml with camera intrinsics and updated instructions in andino_hardware/README Signed-off-by: JesusSilvaUtrera <[email protected]> * Changed the 'camera_info_url' to be relative path Signed-off-by: JesusSilvaUtrera <[email protected]> --------- Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]> Signed-off-by: Gary Servin <[email protected]> Signed-off-by: Javier Balloffet <[email protected]> Co-authored-by: Franco Cipollone <[email protected]> Co-authored-by: Gary Servin <[email protected]> Co-authored-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: JesusSilvaUtrera <[email protected]>

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

…rera/andino into jesus/#237_assembly_process

JesusSilvaUtrera · 2024-09-11T12:14:37Z

@francocipollone @jballoffet this PR is ready for review, I have added the photo of the completed assembly. I know there are some problems with DCO from long ago and I noticed now, but I tried to do the rebase and they are a lot of commits to solve conflicts, so in the meantime you can take a look at the PR to give feedback if there is anything else you'd like to introduce, so we have time before RosCon.

Thanks in advance to both!

Signed-off-by: JesusSilvaUtrera <[email protected]>

JesusSilvaUtrera · 2024-09-13T08:32:23Z

closing as there are too many conflicts to rebase, I will open a new fresh PR with all the final changes, so it's easier to review.

francocipollone requested changes Apr 30, 2024

View reviewed changes

andino_hardware/README.md Outdated Show resolved Hide resolved

andino_hardware/README.md Outdated Show resolved Hide resolved

andino_hardware/README.md Outdated Show resolved Hide resolved

JesusSilvaUtrera requested a review from francocipollone April 30, 2024 14:33

francocipollone previously approved these changes Apr 30, 2024

View reviewed changes

JesusSilvaUtrera dismissed francocipollone’s stale review via 9dc38b0 May 1, 2024 06:35

francocipollone reviewed May 1, 2024

View reviewed changes

JesusSilvaUtrera and others added 16 commits May 10, 2024 11:04

Draft version of the robot assembly

513f336

Signed-off-by: JesusSilvaUtrera <[email protected]>

Changed TODO statements to point to the ticket

4967ae1

Signed-off-by: JesusSilvaUtrera <[email protected]>

Fixed some minor format issues

84d09e4

Signed-off-by: JesusSilvaUtrera <[email protected]>

Update bill of materials (#241)

490d4b0

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added missing parts to the bill of materials and updated the photo of…

672dd4c

… the parts Signed-off-by: JesusSilvaUtrera <[email protected]>

Compressed images for assembly process to avoid heavyweight repository

2957ae9

Signed-off-by: JesusSilvaUtrera <[email protected]>

Converted parts photo to jpg

3e5d6ef

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added tooling section in the bill of materials

89dde46

Signed-off-by: JesusSilvaUtrera <[email protected]>

correct typo in link

91786d9

Signed-off-by: JesusSilvaUtrera <[email protected]>

Merge branch 'humble' into jesus/#237_assembly_process

8b94b21

Updated some typos and new features in README

85b34f2

Signed-off-by: JesusSilvaUtrera <[email protected]>

Merge branch 'jesus/#237_assembly_process' of github.com:JesusSilvaUt…

3c1fa68

…rera/andino into jesus/#237_assembly_process

Added new materials

5412b6b

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added some new photos for the assembly

fdf69f2

Signed-off-by: JesusSilvaUtrera <[email protected]>

Merge branch 'humble' into jesus/#237_assembly_process

874d3d1

Added some missing notes and modified one of the photos

30d57fd

Signed-off-by: JesusSilvaUtrera <[email protected]>

JesusSilvaUtrera and others added 8 commits June 18, 2024 11:24

Just reviewing

2cc3118

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added note about considering a change in the connections diagram

57fc5b8

Merge branch 'humble' into jesus/#237_assembly_process

c2c8fe1

Changed step-up on bill of materials and connections diagram

b09e059

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added a note for the step-up

906c43f

Added photo of the completed assembly

456c416

Signed-off-by: JesusSilvaUtrera <[email protected]>

Merge remote-tracking branch 'upstream/humble' into jesus/#237_assemb…

c27de93

…ly_process

gonzodepedro and others added 22 commits September 11, 2024 14:00

Add a note about not updated diagram (#248)

c89a472

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

fix minor typo in App class (#246)

d0c362c

Signed-off-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Improve Shell unit tests (#245)

cb8d47f

Signed-off-by: Javier Balloffet <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Process xacro file test (#244)

b3bac51

Signed-off-by: JesusSilvaUtrera <[email protected]>

Allow custom configuration (#243)

ec03580

Signed-off-by: JesusSilvaUtrera <[email protected]>

Add new Arduino diagram (#249)

6e51c9d

Signed-off-by: JesusSilvaUtrera <[email protected]>

Update connections diagram (#252)

7c2e8f0

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added some missing notes and modified one of the photos

50358ca

Signed-off-by: JesusSilvaUtrera <[email protected]>

Just reviewing

99b53ce

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added note about considering a change in the connections diagram

ffab582

Signed-off-by: JesusSilvaUtrera <[email protected]>

Adds discord link (#253)

41368bc

Signed-off-by: Franco Cipollone <[email protected]> Co-authored-by: Lola Segura <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

explicitly add <cstdint> header for fixed width integer types (#254)

d1808fa

Signed-off-by: Sakura286 <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Changed step-up on bill of materials and connections diagram

c4554e0

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added a note for the step-up

447279b

Signed-off-by: JesusSilvaUtrera <[email protected]>

Added photo of the completed assembly

7cfbb9f

Signed-off-by: JesusSilvaUtrera <[email protected]>

Updates CHANGELOG.

c055d4a

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

0.2.0

bca5789

Signed-off-by: JesusSilvaUtrera <[email protected]>

Updates README.md

08bb9af

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Adds reference to andino_rmf repo (#263)

72ff583

Signed-off-by: Franco Cipollone <[email protected]> Signed-off-by: JesusSilvaUtrera <[email protected]>

Merge branch 'jesus/#237_assembly_process' of github.com:JesusSilvaUt…

aa6ed0c

…rera/andino into jesus/#237_assembly_process

JesusSilvaUtrera marked this pull request as ready for review September 11, 2024 12:12

JesusSilvaUtrera requested a review from jballoffet as a code owner September 11, 2024 12:12

JesusSilvaUtrera requested a review from francocipollone September 11, 2024 12:12

Fixed a small mistake with an image

c241fc5

Signed-off-by: JesusSilvaUtrera <[email protected]>

JesusSilvaUtrera closed this Sep 13, 2024

JesusSilvaUtrera deleted the jesus/#237_assembly_process branch September 13, 2024 08:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include robot assembly #238

Include robot assembly #238

JesusSilvaUtrera commented Apr 26, 2024

francocipollone left a comment

francocipollone Apr 30, 2024

francocipollone left a comment

francocipollone May 1, 2024

francocipollone May 1, 2024

JesusSilvaUtrera May 1, 2024

JesusSilvaUtrera May 1, 2024

francocipollone May 2, 2024

JesusSilvaUtrera May 2, 2024

francocipollone commented Jun 9, 2024

JesusSilvaUtrera commented Sep 11, 2024

JesusSilvaUtrera commented Sep 13, 2024

Include robot assembly #238

Include robot assembly #238

Conversation

JesusSilvaUtrera commented Apr 26, 2024

🎉 New feature

Summary

Test it

Checklist

francocipollone left a comment

Choose a reason for hiding this comment

francocipollone Apr 30, 2024

Choose a reason for hiding this comment

francocipollone left a comment

Choose a reason for hiding this comment

francocipollone May 1, 2024

Choose a reason for hiding this comment

francocipollone May 1, 2024

Choose a reason for hiding this comment

JesusSilvaUtrera May 1, 2024

Choose a reason for hiding this comment

JesusSilvaUtrera May 1, 2024

Choose a reason for hiding this comment

francocipollone May 2, 2024

Choose a reason for hiding this comment

JesusSilvaUtrera May 2, 2024

Choose a reason for hiding this comment

francocipollone commented Jun 9, 2024

JesusSilvaUtrera commented Sep 11, 2024

JesusSilvaUtrera commented Sep 13, 2024