Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Custom canvas width in landscape mode #338

Open
rainux opened this issue Jul 10, 2023 · 1 comment
Open

[Feature Request] Custom canvas width in landscape mode #338

rainux opened this issue Jul 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rainux
Copy link

rainux commented Jul 10, 2023

Is your feature request related to a problem? Please describe.
Recent iPhone models has a 19.5:9 display ratio, while reading in landscape mode this display ratio will result a view which is too narrow in height.

Describe the solution you'd like
We can allow users to configure the left and right padding for landscape mode of Reading View, so users can got a view balanced in height & width.

Describe alternatives you've considered
I didn't find any alternatives.

Additional context
I've implemented this with fixed padding, but since I'm not very familiar with Swift, didn't make it as a option in Reading Settings yet. If you like this idea, I'll try fully implement it and send PR.

@tatsuz0u
Copy link
Contributor

Thanks for your advice.

A horizontal padding adjustment feature does seem helpful while reading in vertical direction and landscape mode. We will add it to our todo list.

cc @chihchy

@chihchy chihchy added the enhancement New feature or request label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants