-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few notes #125
Comments
I ran into another bug. This manifests itself in a certain situation when controlling via the web interface.
thus:
This resulted in the tracklist index being used instead of the track name (when calling the GET method).
Now it works as expected. |
I have another note. |
I still have to add one correction to the adjustments I made. |
First of all I have to thank you for the great work you have done on this project. I was looking for what I should start from when constructing an Internet radio and your project turned out to be perfect for it.
I was originally based on a version that was about 5 months old. I made quite a few changes in the meantime, so it was quite difficult for me to upgrade to the new version.
But in any case, I had planned to solve the work with the SD card in a better way, so the new version came in handy.
However, I ran into a few bugs:
1) Mute-unmute
This is a good change, if it concerns control via a web interface or perhaps via a serial interface. But there is no button on my remote that can be used for the "unmute" command. So I made a small modification to the code in the SCANIR routine:
2) Callback function for handle_mp3list
There are even 2 bugs in this feature that cause the first and last track to be missing from the mp3 track selection dropdown and one track is always random.
First you need to change
thus:
This is because a few lines later, path = getSDFileName ( i++ ) is used;
As we know, the meaning of i++ is that i is incremented by one, and then it returns the old value of i !
This means that the first time getSDFileName ( i++ ) is called with i=0 it results in a random track being returned.
A zero value of i has another undesirable consequence. The part of the code where the separator is inserted is skipped (and therefore the first track is missing).
Next, the if ( i >= SD_filecount ) code needs to be changed to if ( i > SD_filecount ), because otherwise the last track is missing.
I made many other adjustments - for example, when selecting a track using the encoder, I can scroll through the list backwards (including jumping to the last track if I get "before" the first track).
The text was updated successfully, but these errors were encountered: