Bug while trying to use the plugin

[clemrdh]

Just trying to use the plugin (0.6.1) in win10, with koReader (last version) on D:\ and the Obsidian storage on H:\ .

plugin:obsidian-koreader-plugin:12787 Uncaught (in promise) TypeError: Cannot read property '0' of null
at KOReader.eval (plugin:obsidian-koreader-plugin:12787)
at Generator.next ()
at eval (plugin:obsidian-koreader-plugin:63)
at new Promise ()
at __async (plugin:obsidian-koreader-plugin:47)
at KOReader.createNote (plugin:obsidian-koreader-plugin:12785)
at KOReader.eval (plugin:obsidian-koreader-plugin:12925)
at Generator.next ()
at fulfilled (plugin:obsidian-koreader-plugin:50)

-> Apparently caused by const page = bookmark.text ? parseInt(bookmark.text.match(/\d+/g)[0]) : -1;
-> text.match() is null, so [0] is incorrect.

I don't know if this is due to unaccepted characters in the Book title or other bugs ?

Uncaught (in promise) Error: ENOENT: no such file or directory, mkdir 'H:\Nextcloud\ ...-Christian Arnsperger
Dominique Bourg'

Uncaught (in promise) Error: ENOENT: no such file or directory, open 'H:\Nextcloud\DOCUMENTS\NOTES\OBSIDIAN\04-Other\KoReader_HIghlights(book) Ecologie intégrale_ Pour ...-Christian Arnsperger
Dominique Bourg\on constate que la méthod... - Christian Arnsperger
Dominique Bourg.md'

Uncaught (in promise) Error: ENOENT: no such file or directory, open 'H:\Nextcloud\DOCUMENTS\NOTES\OBSIDIAN\04-Other\KoReader_HIghlights(book) Ecologie intégrale_ Pour ...-Christian Arnsperger
Dominique Bourg\favoriserait une intensif... - Christian Arnsperger
Dominique Bourg.md'

[mthlvt]

+1 had same issue, temporarily fixed it by removing highlights where I had a note added.

Seems Koreader data is different in this case which leads to parsing failure and the uncaught exception.

Steps to reproduce: add a highlight in koreader, then tap the highlight and add a note, try to sync again

[clemrdh]

Pitty, have forked and update the plugin : https://github.com/clemrdh/obsidian-koreader-sync/

Now it works with page numbers, notes, text, ec... all good 👍

[Edo78]

Pitty, have forked and update the plugin : https://github.com/clemrdh/obsidian-koreader-sync/

Now it works with page numbers, notes, text, ec... all good 👍

Sorry I have no time right now but if you are kind enough to open a PR I'll do my best to approve it

[mthlvt]

Pitty, have forked and update the plugin : https://github.com/clemrdh/obsidian-koreader-sync/
Now it works with page numbers, notes, text, ec... all good 👍

Sorry I have no time right now but if you are kind enough to open a PR I'll do my best to approve it

#64

[cedryck1]

@clemrdh

I had the same problem.
Look in the .lua file (in your metadata folder of the book on your Koreader device (folder ending by .sdr)

When there are multiple authors, there may be a line skip with an antislash. Correct it in the .lua file so both authors are on the same line without line skip.

WHIT THE LINE SKIP CAUSING THE ISSUE

WITHOUT THE LINE SKIP (To fix the issue)

[thegreekgeek]

Hey is this ever going to get merged? I seem to be having this same issue.

[moshin34]

Hi. First off thanks for all the hard work that goes into these things! I am very excited to get this going. Can I ask, if I understand this correctly. There was a release on 2/11/22, and it had this bug. Then someone has squashed the bug on 8/26/22 but this fixed code hasn't been merged on 1/5/2025?

Will this be merged @Edo78 ? I know you're busy with life. And I am just someone not smart enough to fix it myself.

@clemrdh I appreciate your work here on this, and Ive downloaded your release. However, I realized quickly that I have no idea how to install your version. Any suggestions or guidance would be appreciated. It would be AMAZING to have this plug in working as a part of my workflow if possible.

Again, tremendous gratitude for all of you making this magic for the rest of us.

Thanks!!

[moshin34]

Hey is this ever going to get merged? I seem to be having this same issue.

Same I hope @Edo78 might be able to merge the bug fix in, if I am reading this right.

[Edo78]

Hey is this ever going to get merged? I seem to be having this same issue.

Same I hope @Edo78 might be able to merge the bug fix in, if I am reading this right.

Sadly the PR was a bit too messy to be merged.