Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

The add button is not disabled #149

Open
Bashamega opened this issue Aug 12, 2024 · 8 comments · May be fixed by #176
Open

The add button is not disabled #149

Bashamega opened this issue Aug 12, 2024 · 8 comments · May be fixed by #176
Assignees
Labels
bug Something isn't working status: ready for dev this issue can be assigned and worked on

Comments

@Bashamega
Copy link
Member

Description

Hello:)

I have noticed that without entering anything in the GitHub URL placeholder the button is still clickable. It should first test against a regex to see if there is a valid GitHub URL.

Screenshots

No response

Additional information

If you are stuck and don't know the correct regex this should work:

^https:\/\/github\.com\/[a-zA-Z0-9_-]+\/[a-zA-Z0-9_-]+$
@Bashamega Bashamega added the bug Something isn't working label Aug 12, 2024
@eddiejaoude eddiejaoude added the status: ready for dev this issue can be assigned and worked on label Aug 12, 2024
@eddiejaoude
Copy link
Member

Thank you 👍

@PadamSinha2511
Copy link
Contributor

Can you please assign this to me, I can work on this.

@eddiejaoude
Copy link
Member

Sure assigned to you @PadamSinha2511

@PadamSinha2511
Copy link
Contributor

PadamSinha2511 commented Aug 14, 2024

I noticed that the compose.yaml file does not have a volume for the app to sync the local development to the container running the application should I add a volume and mount the app directory as

volumes:
- .:/usr/src/app

@eddiejaoude
Copy link
Member

This could be the issue that @Bashamega has. @Pradumnasaraf could you let us know if this is missing or if we are we using another way to achieve this? Thank you

@Pradumnasaraf
Copy link
Member

Pradumnasaraf commented Aug 15, 2024

Hey Eddie,

Sure, @PadamSinha2511 you can add. I was going to implement the compose watch feature instead of bind mount, but realised, that many people don't have the latest version of compose and it won't work, so I didn't implement that. The issue bind mounts it that it didn't work well many times, especially with Next.js apps.

Pradam, do raise a separate PR for that.

@eddiejaoude
Copy link
Member

Thank you @Pradumnasaraf 👍

@PadamSinha2511 please can you raise another issue for the docker compose changes

@PadamSinha2511
Copy link
Contributor

PadamSinha2511 commented Aug 15, 2024

Sure, here is the issue id #167

@PadamSinha2511 PadamSinha2511 linked a pull request Aug 16, 2024 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working status: ready for dev this issue can be assigned and worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants