BREAKING Typed NaturalAbstractDetail.data #9819
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NaturalAbstractDetail.data` is implicitly typed with the result of
`service.resolve()`. If needed that type can be widened by specifying
a type for extra properties in the generic, like so:
```ts
class MyComponent extends NaturalAbstractDetail<MyService, {myProp: string}> {
}
```
`getConsolidatedForClient()` was dropped entirely without a replacement.
It should never be used in our projects (and it was not).
`getDefaultForClient()` was renamed into `getFormExtraFieldDefaultValues()`
to better reflect its usage. It should never be called in projects, only
within Natural itself. Projects were updated to instead call
`getDefaultForServer()`.
The overall behavior of both `NaturalAbstractModelService` and
`NaturalAbstractDetail` is intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaturalAbstractDetail.datais implicitly typed with the result ofservice.resolve(). If needed that type can be widened by specifying a type for extra properties in the generic, like so:getConsolidatedForClient()was dropped entirely without a replacement.It should never be used in our projects (and it was not).
getDefaultForClient()was renamed intogetFormExtraFieldDefaultValues()to better reflect its usage. It should never be called in projects, only within Natural itself. Projects were updated to instead callgetDefaultForServer().The overall behavior of both
NaturalAbstractModelServiceandNaturalAbstractDetailis intact.