Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch zoom to open big image ? #92

Open
spfmoby opened this issue Jul 6, 2023 · 7 comments
Open

Pinch zoom to open big image ? #92

spfmoby opened this issue Jul 6, 2023 · 7 comments

Comments

@spfmoby
Copy link

spfmoby commented Jul 6, 2023

HI

On mobile devices, I would like to be able to open the full size image when I pinch zoom on a thumbnail. Is there a simple way?

@sambaptista
Copy link
Member

sambaptista commented Jul 6, 2023

Hello,

As far as I can tell, you can pinch on mobile to zoom in more than the full image size (until it's pixelated) on the default demo website homepage. I've just tested on android.

Can you provide better explanation on what behavior you experience and what different you expect please ?

@spfmoby
Copy link
Author

spfmoby commented Jul 6, 2023

Sorry if I was not precise enough.

The idea I want to implement is that when you pinch-zoom on a thumbnail it opens the full size picture.
On the demo, for example on the picture with the tent, if you pinch zoom on the thumbnail, you zoom on the thumbnail sized picture, it does not load the full size image.

@sambaptista
Copy link
Member

When you click on a thumbnail, the image opens in photoswipe/lightroom with original size. And then you can zoom on the original sized image.

Do you pinch zoom after clicking on a thumbnail or do you pinch zoom on the page itself without clicking on the thumbnail ?

opens the full size picture

Can you define open ? do you mean photoswipe/lightroom opening, download or something else ?

@spfmoby
Copy link
Author

spfmoby commented Jul 21, 2023

"open" means display the image in a big format over the gallery of thumbnails, AKA opens photoswipe.

I'm not talking trying to zoom on the already big picture in photoswipe, I'm talking trying to pinch-zoom on the gallery of thumbnails

@sambaptista
Copy link
Member

It's not supported and probably conflicting with browser behavior.

Pinch in a page will zoom the page itself, not trigger an even on a specific image. Do you have any example of a gallery opening photoswipe with pinch zoom ?

@spfmoby
Copy link
Author

spfmoby commented Jul 27, 2023

I don't have any photoswype example but it is a behavior I'm witnessing when people look at gallery on their phones, many of them tend to pinch zoom on the thumbnails instead of clicking on a thumbnail to open the image in it's full size.
I'm seen some portfolio websites choosing to load the fullsize images as thumbnails to allow people on smartphone to pinch zoom on the thumb and see the hi-res picture without any other action.
Example : https://heathersham.com/wedding-portfolio/
With lazy loading on the thumbnails maybe it is not such a bad idea on the user side. Everything you see is already loaded at its maximum resolution. But it has a cost on bandwidth and probably a little bit on the user experience as the loading of the thumbnails is slower.

That's why I was trying to implement something in the middle : low-res thumbnails, but open photoswipe as soon as someone pinch-zooms on a picture.

@sambaptista
Copy link
Member

Ok I get the point.

I'll think about it and evaluate the technical implications. But there probably wont be an upgrade soon, it may take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants