Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python/Jupyter extension are outdated #703

Open
jeanp413 opened this issue Sep 7, 2023 · 5 comments
Open

Python/Jupyter extension are outdated #703

jeanp413 opened this issue Sep 7, 2023 · 5 comments
Assignees

Comments

@jeanp413
Copy link
Collaborator

jeanp413 commented Sep 7, 2023

Also:

  • ms-toolsai.jupyter-renderers
  • ms-python.black-formatter
  • ms-python.isort
@filiptronicek
Copy link
Member

Jupyter renderers are re-published. Still not sure about what is causing the issues during our build, but I think we need to look into how we sandbox the build processes again.

@filiptronicek
Copy link
Member

filiptronicek commented Sep 12, 2023

Isort is published now as well, I think it is due to some outdated Node / Python versions we use, so I'm prepping a PR to fix that

Isort ended up being a bigger headache than I expected. It does not have a proper compile guide and the published artifact sizes seem off.

@apollo13
Copy link
Contributor

apollo13 commented Oct 6, 2023

See #711 -- I manually built it using the commands from https://github.com/microsoft/vscode-isort/blob/main/.github/actions/build-vsix/action.yml and it worked fine.

@mammo0
Copy link

mammo0 commented Oct 13, 2023

Maybe #714 is also related to this?

@msujew
Copy link

msujew commented Jul 18, 2024

FYI, we've noticed that even though the universal build of the Jupyter extension contains a browser web extension entry, the extension fails to load in the browser due to incorrectly cross-compiled CommonJS code. It contains top level references to the module object without it being defined.

See also the discussion over at eclipse-theia/theia#13938 where this was first discovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants