Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About adding vscode-flake8 #702

Closed
apollo13 opened this issue Sep 4, 2023 · 5 comments
Closed

About adding vscode-flake8 #702

apollo13 opened this issue Sep 4, 2023 · 5 comments
Assignees

Comments

@apollo13
Copy link
Contributor

apollo13 commented Sep 4, 2023

I'd like to add vscode-flake8 https://github.com/microsoft/vscode-flake8/ to OpenVSX. Since it is a microsoft project I am not sure if it makes much sense to ask them whether they want to publish it. Can I just go ahead and open a PR to this repo or what would be the recommended workflow here? It is MIT licensed so it should be fine to host on OpenVSX

@apollo13
Copy link
Contributor Author

apollo13 commented Sep 4, 2023

Especially with this answer microsoft/vscode-autopep8#102 (comment) I don't expect the answer for flake8 to be different and don't want to create noise on the upstream repo unless necessary.

@jeanp413
Copy link
Collaborator

jeanp413 commented Sep 7, 2023

Hi @apollo13, yes feel free to create a PR for vscode-flake8 and/or vscode-autopep8, we'll look into it early next week

@jeanp413 jeanp413 assigned jeanp413 and filiptronicek and unassigned jeanp413 Sep 7, 2023
@jeanp413
Copy link
Collaborator

jeanp413 commented Sep 7, 2023

Seems there's already a PR for vscode-autopep8 #686

apollo13 added a commit to apollo13/publish-extensions that referenced this issue Sep 8, 2023
@apollo13
Copy link
Contributor Author

apollo13 commented Sep 8, 2023

Ok, added #704, I copied over the build commands from the .github/actions from the original repo, so those should work (and since it matches isort & black we should be safe).

@filiptronicek
Copy link
Member

filiptronicek commented Sep 11, 2023

Aaaaand... published: https://open-vsx.org/extension/ms-python/flake8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants