Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Improve testing #32

Closed
chrisguindon opened this issue Dec 11, 2020 · 1 comment · Fixed by #45
Closed

Improve testing #32

chrisguindon opened this issue Dec 11, 2020 · 1 comment · Fixed by #45
Assignees
@autumnfound @flora8984461

Comments

@chrisguindon
Copy link
Member

chrisguindon commented Dec 11, 2020 •
edited
Loading

It's very hard to test and preview new changes with our new service:
#31 (comment)

I think we can replace the Hugo site with a simple HTML page responsible for displaying new changes proposed in a PR.

We will need to fetch the content of adopters.json instead of making a request to our production API to include the new content in the preview.

I also think we need to add a test that validates the JSON file.

Please discuss!
@chrisguindon chrisguindon mentioned this issue Dec 11, 2020
Merged
@flora8984461 flora8984461 mentioned this issue Dec 17, 2020
Merged
@flora8984461
Copy link
Contributor

flora8984461 commented Jan 25, 2021 •
edited
Loading

A note for me: https://www.npmjs.com/package/jsonlint

@autumnfound autumnfound linked a pull request Jan 26, 2021 that will close this issue
Add a test page #45
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@autumnfound autumnfound

@flora8984461 flora8984461

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a test page flora8984461/eclipsefdn-project-adopters
3 participants
@chrisguindon @autumnfound @flora8984461