Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error downloading model videos #53

Open
AsunaYuuki16 opened this issue Sep 17, 2024 · 6 comments
Open

Error downloading model videos #53

AsunaYuuki16 opened this issue Sep 17, 2024 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@AsunaYuuki16
Copy link

AsunaYuuki16 commented Sep 17, 2024

It fails and aborts after a few videos.
issue
log.log

Edit: Not just model, downloading any video causes an error.

[Converting: 100/100WARNING:phub.core:Call failed: ConnectError('[Errno 104] Connection reset by peer'). Retrying (attempt 1/4)
ERROR:phub.objects.video:Couldn't fetch the Image using HTML scraping

This is the error that comes up.

PS: please add detailed installation guide as some releases are not being installed directly. (especially the linux ones)

@EchterAlsFake
Copy link
Owner

Hi,

Thanks for your report. There are a few questions which I have:

  • Do you live in a country with censored or partially censored internet? (For example China or South Korea)

  • Have you tried without using FFmpeg, for example with the threaded downloader?

If you don't want to tell about the first because of Privacy, it's totally fine.

The error with the image is currently some kind of expected or at least I know about it, and I'll fix it.

I will also test the ffmpeg downloading as soon as I am home :)

EchterAlsFake added a commit that referenced this issue Sep 18, 2024
@AsunaYuuki16
Copy link
Author

AsunaYuuki16 commented Sep 18, 2024

Update: Downloading individual files works perfectly. It shows the error in downloading multiple files, whether it is model or file containing links.
also could not find a way for the folders to work. (might be im not getting how to use it, but just reporting)

To answer your question,

  1. I dont use any vpn so pretty sure not censored in my country
  2. Ive tried both high performance and FFmpeg (im guessing high performance is threaded), that just fails instantly

Tried on windows 11 pro v 23H2:
Uploading single file works , cli and gui work, model link gets links but on clicking download it aborts after a few downloads, uploading a file instanlty aborts

tried on kali linux:
uploading single file works, couldnt use gui as i use linux in headless mode

QOL suggestion: the settings page in the CLI is a bit confusing due to the random colors. A tick or confirmation for selected options would be helpful.

Edit: One more thing idk if it is relevant or not, but after clicking download, it always says failed, HTML scraping failed or smtg like that.

@EchterAlsFake
Copy link
Owner

Thanks for your information. I'll fix it as soon as I can.

And I see what I can do to the settings page xD

@EchterAlsFake EchterAlsFake added bug Something isn't working enhancement New feature or request labels Sep 21, 2024
@EchterAlsFake EchterAlsFake self-assigned this Sep 21, 2024
@AsunaYuuki16
Copy link
Author

Hi, still facing this issue.
Can it be related to multi threading or something similar, as whenever more than a few videos are kept for download (.txt or model or for that matter any batch option), the first few are downloaded and then the rest just throw the error and abort.
Uploading the .txt file does not help as it shows invalid url (this url works if i put the same one directly in the url box)

@EchterAlsFake
Copy link
Owner

Hi, sorry for letting you wait so long. I haven't looked into it yet and I won't be able to in the next week (probably). Thanks for the information.

Yes it could indeed be related to multi threading, although I need to test it on my system first, to reproduce the issue.

Did you change the semaphore in the settings? Like how many videos can be downloaded at the same time? I am not sure, but the default value should be 2 or 3 and I never changed that, so if you did, then it would be good to know, so that I can test with the same conditions.

EchterAlsFake added a commit that referenced this issue Nov 2, 2024
@EchterAlsFake
Copy link
Owner

Alright, so after two months I am finally back in coding, so I can now fix your case.

You said "Uploading the .txt file does not help as it shows invalid url (this url works if i put the same one directly in the url box)". Can I see an example URL where it fails, becaus this would mean, that I need to update the PHUB library to also accept such URL schemes?

You also said "Can it be related to multi threading or something similar, as whenever more than a few videos are kept for download (.txt or model or for that matter any batch option), the first few are downloaded and then the rest just throw the error and abort."

Could you maybe upload the .txt file you were using, so that I can reproduce this issue, because I haven't got it so far.

I also have a third question which is, how many download you have enabled in the same time? It's the semaphore setting in the setting spage, which is by default 2 (or 3 I think). Did you change it or left on default?

And I have corrected the settings page in the CLI. If you want you can download the repositories code and have a look at the new settings page.

Or you can also look at this image:
image

I hope this looks like you have intended me to do it :)

I am sorry that it took so long for me to respond. I hope we can fix it now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants