[FEATURE-36] Create CI/CD pipeline with build-deploy steps #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/home/runner/work/free-programming-books-search/free-programming-books-search/node_modules/react-markdown/index.js:6
export {uriTransformer} from './lib/uri-transformer.js'
^^^^^^
SyntaxError: Unexpected token 'export'
2 | import axios from "axios";
3 |
> 4 | import ReactMarkdown from "react-markdown";
| ^
5 | import rehypeSlug from "rehype-slug";
6 | import rehypeRaw from "rehype-raw";
7 |
using "jest.transformIgnorePatterns"
it already holds the inital code 😟
|
Testing jobs has been fixed in bae6a01 PR ready to review 🚀 |
- 'screen' is defined but never used Fix over 5f24ef9
davorpa
changed the title
torn4dom4n
reviewed
Oct 7, 2022
| if: ${{ false }} | ||
| run: npm run test:e2e | ||
|
|
||
| deploy: |
There was a problem hiding this comment.
I think we can use GitHub deploy pages action here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add feature(s) | Fix
Description
It is well known in any React project that after any modification in its source code (
src/**.js,package.jsonmainly), it is necessary to deploy to production (executingnpm run deploy) if we want to see said changes at https://ebookfoundation.github.io/free-programming-books-searchWell, this pipeline/workflow automates this process as part of a continuous integration cycle (lint-build-test-deploy) by:
npm run deployif push to main branch. Now it's automated.Due to build the artifact in a CI environment I've needed to fix some lint warnings in several⚠️ Pipeline fails if not resolved. See: https://github.com/davorpa/free-programming-books-search/actions/runs/3057895260/jobs/4933516460#step:5:14
*.jsfiles.Context
Resolves #35
The lint-test phases are TODOs because the project requires a refactor to format it according to Prettier/ESLint or current testscases don't pass!!The test phases/jobs are faked. If enabled, it didn't work per-sé. Ssee failed runs:Unfortunatelly I don't know how to fix the integration of create-react-app + jest + babel to work with ES modules. So are conditionally disabled and annotated as TODOs