Fix cylcache to use the same variables as Cylinder.

[michael-petersen]

This pull simply brings cylcache in line with variable names used in src/Cylinder.cc.

It does not make the variables in exputils/EmpCylSL.cc follow the same naming convention. There, lmax and nmax still retain the old sense. However, this is a deeper code change (IMO), so I have left it for now. The variable names are all internally consistent -- just not consistent up to the top (user-exposed) level.

[michael-petersen]

Forgot to tag: this fixes issue #37.

[michael-petersen]

@The9Cat , did the threads test work? If so, I'd suggest the change get committed here. As far as I'm concerned, this is otherwise complete.

[The9Cat]

It took me a few hours to convince myself that the two bases (with single and multiple threads) were the same. Actually, they are not quite the same, but they are isomorphic. That is, some of the eigenfunction spaces have sign flips and come in different orders in the two files; that is n=16 in the single threaded file might be n=17 in the multithreaded file. But they are the same up to sign flips and permutations. This won't matter to the end result as long as the same basis file is used.

Good grief.

[The9Cat]

I do have a question for you on the names of cylcache parameters. Specifically, do we want those parameters to match the keys in Cylinder in EXP and Cylindrical in pyEXP? They are not the same now. E.g. nmax vs NORDER.

[michael-petersen]

The changes in the issue_37 branch do update to NMAX, etc. I did choose to keep capitals for consistency in the file, but that could change. I think all the variables match with Cylinder.cc now, up to the case.

[The9Cat]

Oh, sorry: I changed branches to do the git cherry-pick for the EOF stuff and got confused which branch was which. I suppose this means I checked the wrong version. But if only the parameter names changed, the check itself is still valid.

[The9Cat]

I will go ahead and merge this...

[michael-petersen]

Change summary:

• Variable changes (NMAXFID, LMAXFID, NMAX, NCYLODD)
• Deleted NOUT variable to reduce confusion

Thanks for the merge!