-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MarineAssess updates to recipe_ocean_quadmap.yml #3799
Comments
…ing the necessary chages in the diagnostic script
…lso made to the config files and data files
…pe now runs as expected however with a difference in plot output
… is now working correctly for both sst and sos
…s and delete the unused diagnostic script
…n_quadmap.py script back into the directory
@SophieHall2024 many thanks for opening this and for the subsequent work in the PR. Could I be a bother and ask you to not reference the issue in every commit in the PR, please? This makes the issue comments hard to read since one needs to scroll through countless commits referenced by GitHub. Cheers 🍺 |
OFFICIAL
Yes of course, I apologise! I am still very new to this 😊
OFFICIAL
From: Valeriu Predoi ***@***.***>
Sent: 18 November 2024 12:42
To: ESMValGroup/ESMValTool ***@***.***>
Cc: Sophie Hall ***@***.***>; Mention ***@***.***>
Subject: Re: [ESMValGroup/ESMValTool] MarineAssess updates to recipe_ocean_quadmap.yml (Issue #3799)
This email was received from an external source. Always check sender details, links & attachments.
@SophieHall2024<https://github.com/SophieHall2024> many thanks for opening this and for the subsequent work in the PR. Could I be a bother and ask you to not reference the issue in every commit in the PR, please? This makes the issue comments hard to read since one needs to scroll through countless commits referenced by GitHub. Cheers 🍺
—
Reply to this email directly, view it on GitHub<#3799 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BJVCWTEGVIJ7TJ4RVU6ZQ2L2BHOBTAVCNFSM6AAAAABRD45FDGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBSHEZTINRQGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
@SophieHall2024 absolutely no worries, we've all been new to GitHub at some point 😃 Cheers! |
@valeriupredoi, I often recommend adding the issue number to the start of a commit message (then the commit messages show up on the issue rather than the PR), and I haven't yet spent a lot of time with @SophieHall2024 on GitHub yet, so apologies (to both of you!) for the confusion! 😊 |
no worries at all @ehogan 🍺 Many commits to a PR with the issue number tagged in, will result in a lot of traffic on the issue, whereas discussion items might get lost, if you add the issue number without a |
Short description of the diagnostic
Details will be added @ehogan helping with this.
Branch and pull request
Once you've started working, add the branch (and pull request)
The text was updated successfully, but these errors were encountered: