Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarineAssess updates to recipe_ocean_quadmap.yml #3799

Open
SophieHall2024 opened this issue Nov 4, 2024 · 5 comments
Open

MarineAssess updates to recipe_ocean_quadmap.yml #3799

SophieHall2024 opened this issue Nov 4, 2024 · 5 comments

Comments

@SophieHall2024
Copy link

Short description of the diagnostic
Details will be added @ehogan helping with this.

Branch and pull request
Once you've started working, add the branch (and pull request)

SophieHall2024 added a commit that referenced this issue Nov 7, 2024
SophieHall2024 added a commit that referenced this issue Nov 7, 2024
…ing the necessary chages in the diagnostic script
SophieHall2024 added a commit that referenced this issue Nov 7, 2024
SophieHall2024 added a commit that referenced this issue Nov 7, 2024
…pe now runs as expected however with a difference in plot output
SophieHall2024 added a commit that referenced this issue Nov 12, 2024
… is now working correctly for both sst and sos
SophieHall2024 added a commit that referenced this issue Nov 12, 2024
SophieHall2024 added a commit that referenced this issue Nov 12, 2024
@valeriupredoi
Copy link
Contributor

@SophieHall2024 many thanks for opening this and for the subsequent work in the PR. Could I be a bother and ask you to not reference the issue in every commit in the PR, please? This makes the issue comments hard to read since one needs to scroll through countless commits referenced by GitHub. Cheers 🍺

@SophieHall2024
Copy link
Author

SophieHall2024 commented Nov 18, 2024 via email

@valeriupredoi
Copy link
Contributor

@SophieHall2024 absolutely no worries, we've all been new to GitHub at some point 😃 Cheers!

@ehogan
Copy link
Contributor

ehogan commented Nov 22, 2024

@valeriupredoi, I often recommend adding the issue number to the start of a commit message (then the commit messages show up on the issue rather than the PR), and I haven't yet spent a lot of time with @SophieHall2024 on GitHub yet, so apologies (to both of you!) for the confusion! 😊

@valeriupredoi
Copy link
Contributor

no worries at all @ehogan 🍺 Many commits to a PR with the issue number tagged in, will result in a lot of traffic on the issue, whereas discussion items might get lost, if you add the issue number without a # then it's fine, that won't get piped through as references; having said that, if you would like to highlight a particular commit of interest, then either get the commit hash, or do indeed tag the issue in it like here 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants