Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using recipe_flato13ipcc_figure_914 on CMIP6 data #3729

Open
flicj191 opened this issue Jul 31, 2024 · 4 comments
Open

Using recipe_flato13ipcc_figure_914 on CMIP6 data #3729

flicj191 opened this issue Jul 31, 2024 · 4 comments

Comments

@flicj191
Copy link
Contributor

Describe the bug

I have been using the recipe_flato13ipcc_figure914.yml to produce the plot with CMIP6 data and have found that I have to edit the diagnostic script ipcc_ar5/ch09_fig09_14.py for it to work as it is using the attribute 'model_id' which doesn't exist in CMIP6 attributes so have edited to 'source_id' as well as the plot titles that say CMIP5.

Should we update script and recipe? or make it more configurable?

Attached log.txt from the diagnostic script.

@valeriupredoi
Copy link
Contributor

hi @flicj191 just to confirm esmvaltool/recipes/ipccwg1ar5ch9/recipe_flato13ipcc_figure_914.yml is the one you using, right? In these sort of circumstances, it's always good to tag/assign first the recipe maintainer(s) and/or authors, if they are from among us ie ESMValTool developers taggable on GitHub (@axel-lauer in this case, @LisaBock is a good hit too, since she knows the IPCC stuff inside out), then, if there's no movement from the recipe maintainer(s), ask the scientific community 🍺

@axel-lauer
Copy link
Contributor

axel-lauer commented Sep 25, 2024

My preferred option would be to make the diagnostic script more flexible, i.e. using model_id or source_id depending on the project of the dataset (CMIP5, CMIP6) and as a fallback option (for all other projects) simply the dataset name.

@LisaBock
Copy link
Contributor

There is an updated version of this figure in AR6: Figure 3.24

It was created with ESMValTool (and a python diagnostic) by @ledm and @malininae but the code is not yet merged in the public ESMValTool branch. If you are interested in the new code you could find all information here: https://github.com/ESMValGroup/ESMValTool-AR6-OriginalCode-FinalFigures/blob/main/IPCC_README_files/README_AR6_WG1_Chap3_Fig3_24_sst_bias.md

@malininae
Copy link
Contributor

There is an updated version of this figure in AR6: Figure 3.24

It was created with ESMValTool (and a python diagnostic) by @ledm and @malininae but the code is not yet merged in the public ESMValTool branch. If you are interested in the new code you could find all information here: https://github.com/ESMValGroup/ESMValTool-AR6-OriginalCode-FinalFigures/blob/main/IPCC_README_files/README_AR6_WG1_Chap3_Fig3_24_sst_bias.md

Oh oh, I am planning to merge my IPCC figures still, but not sure when exactly, maybe roughly in half a year?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants