Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge input cubes only once when computing lazy multimodel statistics #2518

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 9, 2024

Description

Merging the input cubes to the multimodel_statistics preprocessor function separately for every statistic computed is time-consuming and unnecessary. This pull request changes the code so the merge is performed only once if at least one input cube has lazy data.

This will help with making recipes run faster in #2316.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the preprocessor Related to the preprocessor label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.83%. Comparing base (4b0dd41) to head (a6227c2).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
- Coverage   94.83%   94.83%   -0.01%     
==========================================
  Files         251      251              
  Lines       14191    14189       -2     
==========================================
- Hits        13458    13456       -2     
  Misses        733      733              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela force-pushed the merge-once-multimodel-statistics branch from e7dfeaf to 0f49e4a Compare September 9, 2024 12:13
@bouweandela bouweandela marked this pull request as ready for review September 11, 2024 07:12
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, bud 🍺

@valeriupredoi valeriupredoi added the enhancement New feature or request label Sep 20, 2024
@schlunma schlunma removed the enhancement New feature or request label Oct 14, 2024
@schlunma schlunma added this to the v2.12.0 milestone Oct 14, 2024
@schlunma schlunma merged commit bd36519 into main Oct 14, 2024
8 checks passed
@schlunma schlunma deleted the merge-once-multimodel-statistics branch October 14, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants