Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CESM moving from use of manage_externals to "git submodules" in cesm3_0_beta01 #450

Open
ekluzek opened this issue Jan 3, 2024 · 3 comments · May be fixed by #485
Open

CESM moving from use of manage_externals to "git submodules" in cesm3_0_beta01 #450

ekluzek opened this issue Jan 3, 2024 · 3 comments · May be fixed by #485
Labels
enhancement Improving usability, performance or other types of enhancements infrastructure issues or code changes related to code organization, data structure, refactoring standalone For stand-alone run
Milestone

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jan 3, 2024

CESM is considering moving from the use of manage_externals to using "git submodules". The CTSM PR that will do this for CTSM is here:

ESCOMP/CTSM#2443

Since, the mizuRoute externals are only used for standalone cases it doesn't need to happen the same time as other CESM components. But, should likely be done fairly soon afterwards as manage_externals is already NOT being supported at this point.

@ekluzek ekluzek added the enhancement Improving usability, performance or other types of enhancements label Jan 3, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 13, 2024

This is happening in roughly a month. So we'll need a PR to do this in mizuRoute. We can check with Jim if he is willing to do it, or if we will need to do it. I think it's not too hard either way.

@ekluzek ekluzek changed the title CESM may move from use of manage_externals to "git submodules" CESM moving from use of manage_externals to "git submodules" in cesm2_3_beta18 Apr 10, 2024
@ekluzek ekluzek changed the title CESM moving from use of manage_externals to "git submodules" in cesm2_3_beta18 CESM moving from use of manage_externals to "git submodules" in cesm3_0_beta01 May 22, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented May 22, 2024

Since, for mizuRoute we only have one external, and it's only needed for offline mizuRoute doing this does NOT need to happen immediately. So when we have a chance we'll update this for offline mizuRoute, but doing this isn't tied to any CESM timelines.

@ekluzek ekluzek added low priority no immediate attention needed standalone For stand-alone run infrastructure issues or code changes related to code organization, data structure, refactoring labels May 22, 2024
@ekluzek ekluzek removed the low priority no immediate attention needed label Jun 26, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 26, 2024

cesm3_0_beta01 has been made where the move to git-fleximod has been done for all other CESM components. So we should now bring this in for mizuRoute.

  • Add "git subtree" for git-fleximod as in other CESM components
  • Update README_EXTERNALS file to mention git-fleximod
  • Update Makefile that mentioned manage_externals
  • Put above into a PR and merge to cesm-coupling
  • Test that git-fleximod functions as we want
  • Bring in remove manage_externals #468 that removes manage_externals

@ekluzek ekluzek added this to the cesm3.0.0 milestone Aug 7, 2024
@nmizukami nmizukami linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving usability, performance or other types of enhancements infrastructure issues or code changes related to code organization, data structure, refactoring standalone For stand-alone run
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant