Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fire_emissions_factors in hist_trop_strat_vbsfire_cam6 usecase #1148

Open
ekluzek opened this issue Sep 12, 2024 · 2 comments
Open

Update fire_emissions_factors in hist_trop_strat_vbsfire_cam6 usecase #1148

ekluzek opened this issue Sep 12, 2024 · 2 comments
Assignees
Labels
answer changing answer changing tag CoupledEval3 misc tag issue or PR candidate for upcoming misc tag

Comments

@ekluzek
Copy link

ekluzek commented Sep 12, 2024

Issue Type

Other (please describe below)

Issue Description

Update the fire_emissions_factors filename in the hist_trop_strat_vbsfire_cam6 to the one being brought into CTSM in ctsm5.3.0.

The change in CTSM is here:

https://github.com/ESCOMP/CTSM/pull/2500/files#diff-efe0e044594e12ba9835f0871f3ffd821575589c8668db139f8bffa25718127a

See:

ESCOMP/CTSM#2734

Will this change answers?

Yes

Will you be implementing this yourself?

No

@ekluzek ekluzek added the answer changing answer changing tag label Sep 12, 2024
@cacraigucar
Copy link
Collaborator

@fvitt - Do you agree that this change is appropriate? Does @cecilehannay need this for her upcoming runs?

@ekluzek
Copy link
Author

ekluzek commented Sep 12, 2024

Adding @tilmes @lkemmons to the discussion. Note, that we talked about this over email with Louisa, Simone, Francis, Will, and Sam R. in the context of CTSM in ESCOMP/CTSM#2734 on Aug/29th. What I then realized is that CAM needs this same update.

The difference in this file from the previous one, is just in Comp_EF and Fang Li @lifang0209 talked about the reason for the changes were that some PFT's had the emission factors incorrectly supplied. For example, Fang found that

For example, the CO2 emission factors for grass and shrub PFTs were incorrectly applied to temperate tree PFTs.

@cacraigucar unless this use case is needed for @cecilehannay upcoming simulations -- this won't be required. Since, this use-case is really specialized I find that doubtful.

@cacraigucar cacraigucar added CoupledEval3 misc tag issue or PR candidate for upcoming misc tag labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answer changing answer changing tag CoupledEval3 misc tag issue or PR candidate for upcoming misc tag
Projects
Status: To Do
Development

No branches or pull requests

3 participants