-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lich-type spells not treated correctly #4098
Comments
joligario
added a commit
that referenced
this issue
Feb 19, 2024
This change breaks lich-type spells as seen in #4098. Per comment on original change, also don't see where Runes come into play.
I’d imagine the intention was to check for rune spell effect. |
Akkadius
pushed a commit
that referenced
this issue
Feb 20, 2024
* [Bug Fix] Revert 2df7d19 This change breaks lich-type spells as seen in #4098. Per comment on original change, also don't see where Runes come into play. * Revert invis change * [Bug Fix] Correct Rune damage check location for invis break. Correct the location of the CommonBreakInvis for runes. Appologize for the incorrect location. Thank you JJ for pointing me to the PR that caused the issue. --------- Co-authored-by: Trust <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Lich-type spells should not break invis. (Fixed in #4101)
Also, the damage should not be mitigated by spell shield type effects.
The text was updated successfully, but these errors were encountered: