New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Invalid data type for appId #4

Open

Avm07 opened this issue Feb 23, 2023 · 0 comments

Avm07 commented Feb 23, 2023

In previous releases appId is defined as string.
https://github.com/EOS-Nation/eosio-wallets/blob/main/src/interfaces.ts#L84

In latest its still the string but required to be eosio::name() type after in the code.
https://github.com/EOS-Nation/eosio-wallets/blob/main/src/wallet.ts#L36

I suggest to use strict types and add eos-common which define needed types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment