Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer crashes when the covariance matrix for a confidence ellipse is not PSD #91

Open
3 tasks
nicolaje opened this issue Nov 6, 2015 · 0 comments
Open
3 tasks
Labels

Comments

@nicolaje
Copy link
Member

nicolaje commented Nov 6, 2015

When a confidence ellipse is drawn from a covariance matrix that is not PSD, the viewer crashes.
Although the client is responsible for sending a correct covariance matrix, the viewer should not crash when a wrong one is passed.

  • Check that the EV of the matrix are positive
  • When only one is positive, draw a circle whose radius is function of the only positive EV
  • When none are positive, do not draw anything

in the last two situations, an error must be logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant