Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example in request-params.Rmd #160

Closed
maelle opened this issue Feb 28, 2024 · 7 comments · Fixed by #169
Closed

update example in request-params.Rmd #160

maelle opened this issue Feb 28, 2024 · 7 comments · Fixed by #169
Labels
documentation Improvements or additions to documentation

Comments

@maelle
Copy link
Collaborator

maelle commented Feb 28, 2024

We have this example code in a pkgdown article

library(EMODnetWFS)

wfs <- emodnet_init_wfs_client("human_activities")

emodnet_get_layers(
  wfs = wfs,
  layers = "maritimebnds",
  featureID = "maritimebnds.861",
  reduce_layers = TRUE
)

However "martimebnds" seems to no longer be a layer for this service.

@salvafern I have two questions

  • is that "maritimebnds" boundary in another service? Did it just disappear? How would user know about changes in available layers?
  • do you know of another example we could use instead in the article. It needs to be a layer with featureIDs (not sure where to find those), a feature we can use to sortBy, enough features for startIndex to be interesting, propertyName to be useful, and it needs geometry to demonstrate filtering by a box. Also how can we choose one that doesn't disappear?

https://github.com/EMODnet/EMODnetWFS/blob/main/vignettes/articles/request-params.Rmd

@maelle maelle added the documentation Improvements or additions to documentation label Feb 28, 2024
@salvafern
Copy link
Collaborator

This layer was temporaly removed from EMODnet due to lifewatch/marineregions-issues#13 - we will update the maritime boundaries product in the next release.

I would say better to not use layers from Human Activities as anything with a political content is more prone to change / disappear. In general layers should not be taken down but I wouldn't be surprised if it happens again without notification. Not sure I have a solution.

I will look for a layer that works as an example

@maelle
Copy link
Collaborator Author

maelle commented Mar 5, 2024

Thank you! I'll wait for an update from you then. 🙏

@maelle
Copy link
Collaborator Author

maelle commented Mar 21, 2024

@salvafern Friendly reminder 😸

@maelle maelle added this to the rOpenSci submission milestone Mar 28, 2024
@maelle
Copy link
Collaborator Author

maelle commented May 10, 2024

@salvafern any update? 😺

@maelle
Copy link
Collaborator Author

maelle commented May 31, 2024

@salvafern friendly reminder 🙂

@salvafern
Copy link
Collaborator

Apologies for overlooking this. I cannot find an example outside human activities, it might be that it is the only lot that uses featureID.

An example in human activities is the layer "pipelines":

library(EMODnetWFS)

wfs <- emodnet_init_wfs_client("human_activities")
#> Loading ISO 19139 XML schemas...
#> Loading ISO 19115 codelists...
#> ✔ WFS client created successfully
#> ℹ Service: "https://ows.emodnet-humanactivities.eu/wfs"
#> ℹ Version: "2.0.0"

emodnet_get_layers(
    wfs = wfs,
    layers = "pipelines",
    featureID = "pipelines.1",
    reduce_layers = TRUE
)
#> Simple feature collection with 1 feature and 13 fields
#> Geometry type: MULTILINESTRING
#> Dimension:     XY
#> Bounding box:  xmin: -5.87186 ymin: 35.99551 xmax: -5.836784 ymax: 36.12588
#> Geodetic CRS:  WGS 84
#>        gml_id   id status medium operator size_in length_m year from_loc to_loc
#> 1 pipelines.1 <NA> Active   <NA>     <NA>    <NA> 15467.17 <NA>     <NA>   <NA>
#>   country_co country notes                       the_geom
#> 1         ES   Spain  <NA> MULTILINESTRING ((-5.87186 ...

Created on 2024-06-25 with reprex v2.1.0

I added a new branch and updated the article. But there are other places in the package where the Maritime Boundaries layer is mentioned (vignette EMODnetWFS and one of the test).

@maelle
Copy link
Collaborator Author

maelle commented Jul 1, 2024

Thank you!! I removed the example from the main vignette. It's a pity!

maelle added a commit that referenced this issue Jul 1, 2024
* fix: switch example layer maritimebnds to pipelines #160

* docs: remove outdate example

---------

Co-authored-by: salvafern <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants