Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the client creation check service_version earlier? #126

Closed
maelle opened this issue Oct 14, 2022 · 2 comments
Closed

Should the client creation check service_version earlier? #126

maelle opened this issue Oct 14, 2022 · 2 comments

Comments

@maelle
Copy link
Collaborator

maelle commented Oct 14, 2022

The current error is not informative.

EMODnetWFS::emodnet_init_wfs_client("bathymetry", "6666")
#> Loading ISO 19139 XML schemas...
#> Loading ISO 19115 codelists...
#> Loading IANA mime types...
#> No encoding supplied: defaulting to UTF-8.
#> ✖ WFS client creation failed.
#> ℹ Service: 'https://ows.emodnet-bathymetry.eu/wfs'
#> ℹ HTTP Status: Success: (200) OK
#> Error: An exception has occurred. Please raise an issue in https://github.com/EMODnet/EMODnetWFS/issues

Created on 2022-10-14 with reprex v2.0.2
@maelle maelle mentioned this issue Oct 14, 2022
Closed
@maelle
Copy link
Collaborator Author

maelle commented Oct 14, 2022

or actually, as @annakrystalli said, we should NOT surface the argument.

@maelle
Copy link
Collaborator Author

maelle commented Jan 20, 2023

#30

@maelle maelle closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maelle