Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure platform-independent path manipulation #30

Open
obo opened this issue Feb 4, 2021 · 3 comments
Open

Ensure platform-independent path manipulation #30

obo opened this issue Feb 4, 2021 · 3 comments
Assignees
@mohammad2928 @srdecny
Labels
enhancement New feature or request

Comments

@obo
Copy link
Contributor

obo commented Feb 4, 2021

Almost all path manipulation operations use string concatenation and / as the directory delimiter.
This is wrong. os.path.join() should be used to build paths and similarly for path splitting.
@obo obo added the enhancement New feature or request label Feb 4, 2021
@mohammad2928
Copy link
Collaborator

It's done.

@obo
Copy link
Contributor Author

obo commented Feb 8, 2021

Hopefully it's complete, let's mark it closed. :-)

@obo obo closed this as completed Feb 8, 2021
@obo
Copy link
Contributor Author

obo commented Mar 23, 2021

Reopening because the new index parser (https://github.com/ELITR/SLTev/blob/index-parser/SLTev/index_parser.py) uses glob.

@obo obo reopened this Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mohammad2928 mohammad2928

@srdecny srdecny

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@obo @mohammad2928 @srdecny