From e90b9bd6accac5a136d76a9d9cb700ab2542155b Mon Sep 17 00:00:00 2001 From: Caspar van Leeuwen <33718780+casparvl@users.noreply.github.com> Date: Thu, 14 Nov 2024 11:48:12 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Sam Moors --- tutorial/mpi4py/mpi4py_portable_mixin.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tutorial/mpi4py/mpi4py_portable_mixin.py b/tutorial/mpi4py/mpi4py_portable_mixin.py index d3b8d573..ce3d6f8e 100644 --- a/tutorial/mpi4py/mpi4py_portable_mixin.py +++ b/tutorial/mpi4py/mpi4py_portable_mixin.py @@ -27,7 +27,7 @@ class EESSI_MPI4PY(rfm.RunOnlyRegressionTest, EESSI_Mixin): compute_unit = COMPUTE_UNIT[CPU] # ReFrame will generate a test for each module that matches the regex `mpi4py` - # This means we implicitely assume that any module matching this name provides the required functionality + # This means we implicitly assume that any module matching this name provides the required functionality # to run this test module_name = parameter(find_modules('mpi4py')) @@ -53,6 +53,14 @@ class EESSI_MPI4PY(rfm.RunOnlyRegressionTest, EESSI_Mixin): # Define a time limit for the scheduler running this test # https://reframe-hpc.readthedocs.io/en/stable/regression_test_api.html#reframe.core.pipeline.RegressionTest.time_limit time_limit = '5m00s' + + # Define the benchmarks that are available in the test. + # In this test (`EESSI_MPI4PY`) there is only one benchmark. If there are more than one, + # define them using the `parameter()` function. + bench_name = 'mpi4pi' + + # Specify the benchmark to be tested in CI (will be marked with a `CI` tag). + bench_name_ci = 'mpi4pi' # Define the class method that returns the required memory per node def required_mem_per_node(self):