Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that CUDA(-dependent) builds are always done in an accelerator prefix #823

Open
bedroge opened this issue Nov 21, 2024 · 2 comments

Comments

@bedroge
Copy link
Collaborator

bedroge commented Nov 21, 2024

I accidentally triggered a CUDA+UCX-CUDA build for zen2 without accelerator target in #817 (comment), and this worked fine, so I almost overlooked that I overlooked that I forgot to specify the accelerator target. It would be nice to have some check (CI, hook?) in place that prevents us from doing that, i.e. to make sure that these CUDA builds always are done in an accelerator prefix.

@ocaisa
Copy link
Member

ocaisa commented Nov 21, 2024

We should be able to do that via an EasyBuild hook (should be just another piece of logic alongside what is currently there when checking CUDA dependencies)

@ocaisa
Copy link
Member

ocaisa commented Nov 21, 2024

Should be a matter of checking the install path at https://github.com/EESSI/software-layer/blob/2023.06-software.eessi.io/eb_hooks.py#L945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants