Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control center in PR description #96

Open
trz42 opened this issue Dec 3, 2022 · 4 comments
Open

Control center in PR description #96

trz42 opened this issue Dec 3, 2022 · 4 comments

Comments

@trz42
Copy link
Contributor

trz42 commented Dec 3, 2022

Provide an overview of the status of the PR and means to control instances (disable/enable instances and/or targets, deploy builds for specific instance/target).

Could be implemented by a "master" bot instance which receives all events (PR opened, labelled and particularly updates to comments).

Add mockups of the layout in subsequent comments to this issue.

Maybe a simple table that is added to the very first comment. Table could look as follows

Target Build Step
(Submit/Release/Run/Finish)
Deploy Step
(Upload/Stage/Approve/Ingest)
Bot Instance
x86_64-generic ✅ / ✅ / ✅ / ✅ ✅ / ✅ / ✅ / ✅ Saga-PR62
x86_64-intel-haswell ✅ / ✅ / ✅ / ❌ - / - / - / - CitC-PR62
aarch64-generic ✅ / ✅ / ✅ / ✅ ✅ / ✅ / ✅ / ✅ eX3-PR62
aarch64-generic ✅ / ✅ / ✅ / ✅ ✅ / ✅ / ✅ / ✅ CitC-PR62
aarch64-graviton2 ✅ / ✅ / ✅ / ✅ - / - / - / - CitC-PR62

OR

Target Submitted Released Running Finished Uploaded Staged Approved Ingested Bot Instance
x86_64-generic Saga-PR62
x86_64-intel-haswell CitC-PR62
aarch64-generic eX3-PR62
aarch64-generic CitC-PR62
aarch64-graviton2 CitC-PR62

OR

PRSO (Pull Request Status Overview)

target confirmed built validated deployed verified comments
x86_64-generic 👍 link(s) to details
x86_64-amd-zen2 👍 link(s) to details

(GHA could add a second comment used as command log: confirm <target>, approve <target>, deploy <target>, etc.)

@trz42
Copy link
Contributor Author

trz42 commented Mar 12, 2023

Bot instance at name with defined targets:

arch repo/version config builds deployment
x86_64/generic NESSI/2022.11 enabled 🏃approved
aarch4/generic NESSI/2022.11 disabled --

Last state changes ($n$ per target)

date arch+repo/version job id action/state details
tomorrow aarch64/generic+NESSI/2022.11 1234 submitted job dir /tmp/foo
All jobs (human readable, one table per job)
date arch+repo/version job id action/state details
tomorrow aarch64/generic+NESSI/2022.11 1234 submitted job dir /tmp/foo
today aarch64/generic+NESSI/2022.11 1234 submitted job dir /tmp/foo
yesterday aarch64/generic+NESSI/2022.11 1234 submitted job dir /tmp/foo
date arch+repo/version job id action/state details
tomorrow x86_64/generic+NESSI/2022.11 5678 submitted job dir /tmp/foo
today x86_64/generic+NESSI/2022.11 5678 submitted job dir /tmp/foo
yesterday x86_64/generic+NESSI/2022.11 5678 submitted job dir /tmp/foo

job ABCD arch x86_64/generic repo NESSI/2022.11

date action/state details
tomorrow submitted job dir /tmp/foo
today submitted job dir /tmp/foo
yesterday submitted job dir /tmp/foo
All state changes (machine readable, `json`)
{ "date 1" }

Commands
Note, add commands to the bot below. Keep the ones which are there. Add new at the end of the list. See DOC for a list of supported commands.
Example 1: @bot cancel job 12345
Example 2: @bot disable target aarch64/generic for NESSI/2022.11


**Notes** - why all these checksum errors

@bedroge
Copy link
Contributor

bedroge commented Sep 29, 2023

While reviewing EESSI/software-layer#328, I also figured that it would be very useful to have something like this. The PRs had quite a few build issues, and multiple rebuilds were triggered in attempts to solve these issues, which makes it hard for a reviewer to determine the actual state of the builds/PR.

@laraPPr
Copy link
Collaborator

laraPPr commented Jan 24, 2024

I have created a bot: status command which collects all the comments in the pr related to the bot: build command which then print an overveiw of all the build in one table. I'll open a pr for it once I have cleaned some things up.

@laraPPr
Copy link
Collaborator

laraPPr commented Jan 25, 2024

Just opened #237 to create a bot: status command.

also tested it and here is an example of what the command does:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants