Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code for build/deploy permission check #180

Closed
bedroge opened this issue May 9, 2023 · 2 comments
Closed

Refactor code for build/deploy permission check #180

bedroge opened this issue May 9, 2023 · 2 comments

Comments

@bedroge
Copy link
Contributor

bedroge commented May 9, 2023

There's some (almost) identical code in these checks, this could be refactored in such a way that both make use of a single function.

@jonas-lq
Copy link
Collaborator

jonas-lq commented May 10, 2023

This was already addressed in a later commit in #171

see:

def create_comment(repo_name, pr_number, comment):
)

Maybe I should have made it clearer that I actually fixed it.

@bedroge
Copy link
Contributor Author

bedroge commented May 10, 2023

Ah, right, sorry, guess I misunderstood the comment and didn't check properly :-). Closing this...

@bedroge bedroge closed this as completed May 10, 2023
@boegel boegel added this to the 0.1.0 - initial release milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants