[WIP] MultiFabRegister: throw in get
#5356
Open
+116
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
cleaning
Throw a runtime exception instead of returning a `nullptr` if a field is requested via the getter.
ax3l
force-pushed
the
mf-register-throw
branch
from
cb253dd
to
2c2f48c
Compare
ax3l
changed the title
throw in getthrow in get
|
Discussed with @RemiLehe offline: The functions We will try to add to |
EZoni
requested changes
Oct 19, 2024
Comment on lines
+353
to
354
| throw std::runtime_error("MultiFabRegister::get name does not exist in register: " + internal_name); | ||
| return nullptr; |
There was a problem hiding this comment.
I think we can remove this:
Suggested change
| throw std::runtime_error("MultiFabRegister::get name does not exist in register: " + internal_name); | |
| return nullptr; | |
| throw std::runtime_error("MultiFabRegister::get name does not exist in register: " + internal_name); |
Comment on lines
+367
to
368
| throw std::runtime_error("MultiFabRegister::get name does not exist in register: " + internal_name); | ||
| return nullptr; |
There was a problem hiding this comment.
I think we can remove this:
Suggested change
| throw std::runtime_error("MultiFabRegister::get name does not exist in register: " + internal_name); | |
| return nullptr; | |
| throw std::runtime_error("MultiFabRegister::get name does not exist in register: " + internal_name); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5319
Follow-up to #5230
nullptrif a field is requested via the getter.