Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact matches in ontology sources are only "Good" mapping confidence - should be high? #85

Open
jamesamcl opened this issue Nov 15, 2021 · 6 comments

Comments

@jamesamcl
Copy link
Member

Example to reproduce:

  1. Don't search in any datasources, ontology source EFO
  2. Search for "complement C4b measurement"

The confidence of the match is "Good". However, it is an exact string match - why is this not a "High" confidence match?

Screenshot 2021-11-15 at 15 03 47

@henrietteharmse

@henrietteharmse
Copy link
Contributor

henrietteharmse commented Nov 16, 2021 via email

@jamesamcl
Copy link
Member Author

Here is another exact match from EFO, but this time it only returns MEDIUM.

Screenshot 2021-11-24 at 15 51 37

@henrietteharmse
Copy link
Contributor

This is expected behavior when more than 1 mapping is returned for the same string of text.

@jamesamcl
Copy link
Member Author

But the search was against the EFO ontology, not a datasource with curated mappings. One of the matches was an exact text match, the other wasn't, yet they both get the same confidence. That seems wrong to me.

@henrietteharmse
Copy link
Contributor

Ah, what you mean is that is the second 1 should not have come up as a match... or being rank lower. You may have a point.

@henrietteharmse
Copy link
Contributor

For interest sake this call against OLS returns the desired result: https://www.ebi.ac.uk/ols/api/search?q=Apolipoprotein+E+measurement&groupField=iri&exact=on&start=0&ontology=efo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants