Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OG-ZAF not compatible with OG-Core 0.11.13 #59

Closed
rickecon opened this issue Jul 28, 2024 · 2 comments
Closed

OG-ZAF not compatible with OG-Core 0.11.13 #59

rickecon opened this issue Jul 28, 2024 · 2 comments

Comments

@rickecon
Copy link
Collaborator

@jdebacker. I just recreated the conda environment ogzaf-dev that included the new version of OG-Core (v0.11.13). I ran the run_og_zaf.py file and got the following error. I think this is coming from the new pension adjustments.

(ogzaf-dev) richardevans@Richards-MacBook-Pro-2 examples % python run_og_zaf.py
Number of workers =  7
Traceback (most recent call last):
  File "/Users/richardevans/Docs/Economics/OSE/OG-ZAF/examples/run_og_zaf.py", line 139, in <module>
    main()
  File "/Users/richardevans/Docs/Economics/OSE/OG-ZAF/examples/run_og_zaf.py", line 49, in main
    p.update_specifications(
  File "/opt/anaconda3/envs/ogzaf-dev/lib/python3.11/site-packages/ogcore/parameters.py", line 440, in update_specifications
    self.adjust(revision, raise_errors=raise_errors)
  File "/opt/anaconda3/envs/ogzaf-dev/lib/python3.11/site-packages/paramtools/parameters.py", line 257, in adjust
    return self._adjust(
           ^^^^^^^^^^^^^
  File "/opt/anaconda3/envs/ogzaf-dev/lib/python3.11/site-packages/paramtools/parameters.py", line 375, in _adjust
    raise self.validation_error
paramtools.exceptions.ValidationError: {
    "errors": {
        "schema": [
            "Unknown field: AIME_num_years"
        ]
    }
}

@jdebacker
Copy link
Collaborator

@rickecon Yes, this is due to a parameter name change: AIME_num_years -> avg_earn_num_years.

@jdebacker
Copy link
Collaborator

Addressed via PR #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants