Constant call getAllNetworks() ... why ?

[ims21]

Why is there in Owif called in httpserver.py getAllNetworks() each 15second and always, when is used any item in Owif?
F.eg press Edit Bouquet means 5times call, Autotimer cca 4times.

There is then called getAdapterAttribute twice. E2 has there in getAdapterAttribute debug message - then it is displayed in debug log and is difficult anything debuging, when there is list still moved with this messages ... Why it must be checked each 15 seconds and on each controll item ?

[jbleyel]

getAllNetworks will be called in getChildWithDefault on each request.

You can think about to improve this if you like.

[ims21]

and what about call getAdapterAttribute with 'webif=True' and then there in e2 could be print limited for webif=False only ...

[jbleyel]

This will only hide the root cause and this is very bad programming style.

[jbleyel]

By the way.
getAllNetworks in getChildWithDefault will be only called if you have disabled the authentication to detect local network.

e2openplugin-OpenWebif/plugin/httpserver.py

Lines 346 to 347 in d9d763b

	if (not request.isSecure() and config.OpenWebif.auth.value is False) or (request.isSecure() and config.OpenWebif.https_auth.value is False):
	networks = getAllNetworks()

[ims21]

And ? I must enable auth in local network to disable this and then fill it for all boxes on all PCs ?

[Papi2000-new]

Yes, everyone should use the password for the user root, and should not operate the boxes without a password in his network, even if it is in the internal network. You don't have set permissions to connect to your pcs and other devices?

[WanWizard]

That is for everybody to decide, and not an excuse for bad programming (either here or in E2).