Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14 * possible use of wrong binary operator ? #30

Open
dcb314 opened this issue Sep 8, 2022 · 1 comment
Open

14 * possible use of wrong binary operator ? #30

dcb314 opened this issue Sep 8, 2022 · 1 comment
Assignees

Comments

@dcb314
Copy link

dcb314 commented Sep 8, 2022

fedora/pass300/20220906/catch22.spec.out:IN_AutoMutualInfoStats.c:44:19: warning: suggest parentheses around comp
arison in operand of '&' [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:PD_PeriodicityWang.c:66:20: warning: suggest parentheses around comparis
on in operand of '&' [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:PD_PeriodicityWang.c:72:25: warning: suggest parentheses around comparis
on in operand of '&' [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:SB_BinaryStats.c:40:20: warning: suggest parentheses around comparison i
n operand of '|' [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:SB_BinaryStats.c:78:20: warning: suggest parentheses around comparison i
n operand of '|' [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:SP_Summaries.c:86:13: warning: suggest parentheses around comparison in
operand of '&' [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:splinefit.c:606:14: warning: suggest parentheses around comparison in op
erand of '&' [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:../C/IN_AutoMutualInfoStats.c:44:19: warning: suggest parentheses around
comparison in operand of ‘&’ [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:../C/PD_PeriodicityWang.c:66:20: warning: suggest parentheses around com
parison in operand of ‘&’ [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:../C/PD_PeriodicityWang.c:72:25: warning: suggest parentheses around com
parison in operand of ‘&’ [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:../C/SB_BinaryStats.c:40:20: warning: suggest parentheses around compari
son in operand of ‘|’ [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:../C/SB_BinaryStats.c:78:20: warning: suggest parentheses around compari
son in operand of ‘|’ [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:../C/SP_Summaries.c:86:13: warning: suggest parentheses around compariso
n in operand of ‘&’ [-Wparentheses]
fedora/pass300/20220906/catch22.spec.out:../C/splinefit.c:606:14: warning: suggest parentheses around comparison
in operand of ‘&’ [-Wparentheses]

I checked the first two, presumably the rest are the same.

@benfulcher benfulcher assigned benfulcher and chlubba and unassigned benfulcher Sep 8, 2022
@benfulcher
Copy link
Collaborator

@chlubba Someone doesn't know how to write a nice title for a GitHub Issue, but we should fix these warnings. Doesn't seem to affect the behavior, but best practice would be to convert & to && for the logical AND. (thanks @olivercliff for a quick look and tips).

@dcb314 dcb314 changed the title Someone doesn't understand the difference between && and & in C 14 * possible use of wrong binary operator ? Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants