Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerSentEvents Transport fails to abort underlying connection if transport is timed out #298

Open
1 task
joeldart opened this issue Oct 24, 2018 · 0 comments
Open
1 task

ServerSentEvents Transport fails to abort underlying connection if transport is timed out #298

joeldart opened this issue Oct 24, 2018 · 0 comments

Comments

@joeldart
Copy link
Member

Description

Opens a Connection to a Server and Tries serverSentEvents

But Fails and calls callback to notify the autotransport.
AutoTransport then tries the next best transport SSE

BUT it does not close the underlying connection or clean up the callbacks, so we end up receiving messages from both.

This causes confusion by the Autotransport when later in the transport lifecycle it needs to communicate events to the actual transport doing work. AutoTransport in this case "thinks" LP is processing messages but in reality SSE is processing messages

Replication Steps

Dev Requirements

  • Cancel SSE connection when connectTimeout occurs

Fixed In

Testing

Same as #246
joeldart added a commit that referenced this issue Oct 24, 2018
@joeldart
#298 except for serverSentEvents
3628a5d 
- Found a case that if you slow down sse transport then both transports
will be active causing a number of issues. Looks like we found that
before
- added completion block to see negotiate as well for #276
joeldart added a commit that referenced this issue Oct 25, 2018
@joeldart
#298 updating pod file, etc
041ce77
joeldart added a commit that referenced this issue Nov 1, 2018
@joeldart
#298 do not implicitly retain
81d86f6
joeldart added a commit that referenced this issue Nov 1, 2018
@joeldart
#298 typo - do not implicitly retain
a2415dc
joeldart added a commit that referenced this issue Nov 27, 2018
@joeldart
#298 : clear out handlers when there is a completionHandler
5d92e47 
- sse will continue reconnecting even if the connection is no longer
referencing the transport if you use it directly. dereference
everything so that it will not attempt to reconnect after being stopped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeldart