Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] prevent getting results for gradient border if there is no input #432

Closed
2 of 4 tasks
Dun-sin opened this issue Aug 1, 2023 · 11 comments
Closed
2 of 4 tasks
Assignees
Labels
assigned Issue is no longer available for anyone else to work on feature

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 1, 2023

Description

Users are allowed to click on results even if there's no input given to the generator:
Tasks:

  • add an error indicator for if the button is clicked and there's no input, look at the gradient text generator for an example
  • change the background of the get results button to be gray, if there's no input yet

Screenshots

image

Additional information

No response

👀 Have you checked if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

@Dun-sin Dun-sin added the feature label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

@Dun-sin Dun-sin added the up for grabs Issue is still available for anyone to work on label Aug 1, 2023
@1rayanharoon
Copy link

I want to do this. Can you assign it to me?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 3, 2023

I want to do this. Can you assign it to me?

Definitely, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed.
Good Luck

@Dun-sin Dun-sin added assigned Issue is no longer available for anyone else to work on and removed up for grabs Issue is still available for anyone to work on labels Aug 3, 2023
@1rayanharoon
Copy link

Hey, hope you are doing well. You said that an error message should be displayed when there is no input and gave an example of gradient text generator, but in gradient text generator the error message is displayed if there is no input in text area, if any other field is left without input it still directs us to next page. Can you please specify, in gradient border generator, which input field should not be left without an error. Also I am new to open source. Please do not mind if ask questions. Thanks

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 5, 2023

Hey, hope you are doing well. You said that an error message should be displayed when there is no input and gave an example of gradient text generator, but in gradient text generator the error message is displayed if there is no input in text area, if any other field is left without input it still directs us to next page. Can you please specify, in gradient border generator, which input field should not be left without an error. Also I am new to open source. Please do not mind if ask questions. Thanks

No worries mate you are free to ask questions.
The input field doesn't need to be a input text, the color input and the degree. And it shouldn't be an error message, but a shaking animation like gradient text

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 12, 2023

@1rayanharoon an update on this please?

@1rayanharoon
Copy link

Sorry for being late, last few days were very hard for me. I'll update you as soon as possible. I am working on it. Sorry for the inconvenience caused.

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 22, 2023

@1rayanharoon you got it now? Feel free to drop it if you can't do it, no problem

@1rayanharoon
Copy link

I am sorry, I was a newbie in this but I thought, with some effort I could do it. Really sorry for wasting your time. Appreciate your kindness. Thanks a lot.

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 26, 2023

I am sorry, I was a newbie in this but I thought, with some effort I could do it. Really sorry for wasting your time. Appreciate your kindness. Thanks a lot.

That means you want to drop it?

@1rayanharoon
Copy link

Yes

@Dun-sin Dun-sin closed this as completed Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Issue is no longer available for anyone else to work on feature
Projects
None yet
Development

No branches or pull requests

2 participants