Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] prevent getting results for box shadow if there is no input #431

Closed
2 of 4 tasks
Dun-sin opened this issue Aug 1, 2023 · 9 comments · Fixed by #443
Closed
2 of 4 tasks

[FEATURE] prevent getting results for box shadow if there is no input #431

Dun-sin opened this issue Aug 1, 2023 · 9 comments · Fixed by #443
Assignees
Labels
assigned Issue is no longer available for anyone else to work on feature released

Comments

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 1, 2023

Description

Users are allowed to click on results even if there's no input given to the generator:
Tasks:

  • add an error indicator for if the button is clicked and there's no input, look at the gradient text generator for an example
  • change the background of the get results button to be gray, if there's no input yet

Screenshots

image

Additional information

No response

👀 Have you checked if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

None

@Dun-sin Dun-sin added feature up for grabs Issue is still available for anyone to work on labels Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

It's great having you contribute to this project by creating an issue

Make sure you are assigned to this before you work on it and you read the Contributing.md file, Thank you! Welcome to the community 🤓

@aqsaaqeel
Copy link
Contributor

Can I work on this?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 15, 2023

Can I work on this?

Sure, thanks for wanting to contribute, Make sure you follow the rules 👉🏽here👈🏽, else your PR will not be accepted and will be closed. Good Luck

@Dun-sin Dun-sin added assigned Issue is no longer available for anyone else to work on and removed up for grabs Issue is still available for anyone to work on labels Aug 15, 2023
@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 22, 2023

Hi @aqsaaqeel an update on this please?

@aqsaaqeel
Copy link
Contributor

Hi @aqsaaqeel an update on this please?

I need some time.

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 23, 2023

Hi @aqsaaqeel an update on this please?

I need some time.

can you be more definite?

@aqsaaqeel
Copy link
Contributor

Hi @aqsaaqeel an update on this please?

I need some time.

can you be more definite?

like a day?

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 25, 2023

Hi @aqsaaqeel an update on this please?

I need some time.

can you be more definite?

like a day?

Fair enough, you have 2 days then, incase something unexpected happens.

@Dun-sin
Copy link
Owner Author

Dun-sin commented Aug 29, 2023

🎉 This issue has been resolved in version 2.64.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Issue is no longer available for anyone else to work on feature released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants