Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't move windows to appropriate workspaces when unplugging motnitors #44

Open
UwUnyaa opened this issue Jan 29, 2024 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@UwUnyaa
Copy link
Contributor

UwUnyaa commented Jan 29, 2024

When unplugging monitors (for example, unplugging a dock from a laptop), this plugin doesn't move windows to appropriate workspaces on an existing monitor. This doesn't match dwm behavior, and makes for a poor experience with laptop setups.

I'm working on a (hacky) implementation of such a feature myself on my fork: https://github.com/UwUnyaa/split-monitor-workspaces/tree/handle-unplugging-monitors
This issue exists here to be in place for a possible pull request if needed, as well as any feedback regarding the behavior.

While I'm working on it (I need to beef up my debug setup with robust networking and a separate machine to run a debugger on), my question is, should the plugin attempt to move windows to appropriate workspaces on a monitor with the highest id, or should it move them to the zeroth monitor?

@stejcon
Copy link

stejcon commented Feb 2, 2024

Would it be possible to have that as a configuration option? There are use cases I can think of for both highest id or zeroth id, so it might be nice to have that be configurable.

@iddm
Copy link

iddm commented Feb 8, 2024

Same thing. It used to work for like six months or so but now stopped working.

@UwUnyaa
Copy link
Contributor Author

UwUnyaa commented Feb 8, 2024

@stejcon While it's not working yet, it's totally possible to handle that via a single config setting, which I've added.

@UwUnyaa
Copy link
Contributor Author

UwUnyaa commented Feb 14, 2024

I think it's time for me to throw in the towel. The developer experience with Hyprland barely working with the feature I'm writing around, as well as C++ development in general, especially when you can't really have a decent way to trigger your code in the scenario you're testing around is quite annoying. I feel like I've been dragging myself to work on this for far too long as is. Feel free to take code from my branch and do whatever to it if anyone finds that code of any use. I have a guess as to why it crashes, but I don't feel like spending an hour to even trigger that with a GDB instance doing network debugging, when I'm already considering moving to a compositor that's more funcional and fits my use case better.

@zjeffer zjeffer added the enhancement New feature or request label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants