Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in install script #26

Closed
wants to merge 4 commits into from
Closed

Conversation

zjeffer
Copy link

@zjeffer zjeffer commented Oct 28, 2023

I made some improvements to the install script that made it easier for me to debug problems, so I thought I'd share them.

Comment on lines -27 to +40
git -C "$HYPRLAND_PATH" pull
info "Updating existing hyprland source"
git -C "$HYPRLAND_PATH" pull origin main
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed git pull doesn't always seem to work (when already checked out to a specific commit), specifying origin main fixed that.

@leftas
Copy link

leftas commented Nov 3, 2023

While you are at it, when checking out the specific commit, make sure to update the submodules, as well.
Probably this should suffice: git -C "$HYPRLAND_PATH" submodule update --recursive

Current flow - is that if git has updated to the newest wlroots or other submodules, which also has some breaking changes with regard to checked out version, then the script may fail to build hyprland. For example, as of now, we have v0.31 version and current git version which fails to build because wlroots, which are used in git version, made some breaking changes for v0.31 version.

@zjeffer
Copy link
Author

zjeffer commented Nov 5, 2023

Also fixed #27 in latest commit.

@zjeffer
Copy link
Author

zjeffer commented Mar 10, 2024

Closing due to deprecation

@zjeffer zjeffer closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants