Add preview test #97

sobaya-0141 · 2022-09-02T14:23:35Z

Overview (Required)

ScreenshotTest by Paparazzi added

Links

Add automatic preview screenshot testing with Paparazzi and Showkase android/nowinandroid#101

add ci setting

github-actions · 2022-09-02T14:27:31Z

preview-screenshots/src/test/java/io/github/droidkaigi/confsched2022/PreviewScreenshotTests.kt

+            }
+        }
+    }
+}


[spotless] _{reported by reviewdog 🐶}

Suggested change

}

}

github-actions · 2022-09-02T14:27:31Z

...iew-screenshots/src/test/java/io/github/droidkaigi/confsched2022/ScreenshotShowkaseModule.kt

+import com.airbnb.android.showkase.annotation.ShowkaseRootModule
+
+@ShowkaseRoot
+class ScreenshotShowkaseModule : ShowkaseRootModule


[spotless] _{reported by reviewdog 🐶}

Suggested change

class ScreenshotShowkaseModule : ShowkaseRootModule

class ScreenshotShowkaseModule : ShowkaseRootModule

# Conflicts: # gradle/libs.versions.toml

github-actions · 2022-09-03T11:54:44Z

feature-sessions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/Sessions.kt

@@ -29,6 +29,8 @@ import com.google.accompanist.pager.rememberPagerState
 import io.github.droidkaigi.confsched2022.designsystem.theme.KaigiScaffold
 import io.github.droidkaigi.confsched2022.designsystem.theme.KaigiTheme
 import io.github.droidkaigi.confsched2022.feature.sessions.SessionsUiModel.ScheduleState.Loaded
+import io.github.droidkaigi.confsched2022.feature.sessions.SessionsUiModel.ScheduleState.Loading
+import io.github.droidkaigi.confsched2022.model.DroidKaigiSchedule


[spotless] _{reported by reviewdog 🐶}

Suggested change

import io.github.droidkaigi.confsched2022.model.DroidKaigiSchedule

sobaya-0141 · 2022-09-03T12:08:41Z

Related paparazzi Issues
cashapp/paparazzi#565
cashapp/paparazzi#489 (comment)

takahirom · 2022-09-04T15:04:36Z

Please make sure that the addition of screen shots are not in the history due to the repository size. I think you can rebase and squash the commit. 🙏

github-actions · 2022-09-05T01:58:02Z

...butors/src/main/java/io/github/droidkaigi/confsched2022/feature/contributors/Contributors.kt

+import io.github.droidkaigi.confsched2022.model.Contributor
+import io.github.droidkaigi.confsched2022.model.fakes


[spotless] _{reported by reviewdog 🐶}

Suggested change

import io.github.droidkaigi.confsched2022.model.Contributor

import io.github.droidkaigi.confsched2022.model.fakes

github-actions · 2022-09-05T07:41:55Z

There is a Diff in the screenshot

github-actions · 2022-09-05T11:40:05Z

There is a Diff in the screenshot

github-actions · 2022-09-05T11:47:08Z

There is a Diff in the screenshot

github-actions · 2022-09-05T11:55:44Z

There is a Diff in the screenshot

github-actions · 2022-09-05T12:29:24Z

There are differences in Compose previews. Please check your build and download the diff artifact.
https://github.com/DroidKaigi/conference-app-2022/actions/workflows/ScreenShotTest.yml

# Conflicts: # feature-sessions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/Sessions.kt

# Conflicts: # gradle/libs.versions.toml

sobaya-0141 · 2022-09-06T02:47:29Z

Conflicts resolved.

github-actions · 2022-09-06T02:49:59Z

There are differences in Compose previews. Please check your build and download the diff artifact.
https://github.com/DroidKaigi/conference-app-2022/actions/workflows/ScreenShotTest.yml

hkusu · 2022-09-06T05:41:55Z

.github/workflows/ScreenShotTest.yml

+        with:
+          message: |
+            There are differences in Compose previews. Please check your build and download the diff artifact.
+            https://github.com/DroidKaigi/conference-app-2022/actions/workflows/ScreenShotTest.yml


It might be kinder to write https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}

Thank you for your comment.
I will fix it the way you taught me.

hkusu · 2022-09-06T05:42:47Z

.github/workflows/ScreenShotTest.yml

+    branches:
+      - main


push: branches: - main

This may not be necessary, because it should work only at the time of pull request as it is only for pull requests.

You're absolutely right.

hkusu · 2022-09-06T07:21:20Z

.github/workflows/ScreenShotTest.yml

+        run: ./gradlew preview-screenshots:verifyPaparazziDebug
+
+      - name: Error Screenshot tests
+        continue-on-error: true


This may not be necessary, because the verifyPaparazziDebug step specifies continue-on-error: true, so it will always succeed.

I forgot to delete this one:sweat_smile:

hkusu · 2022-09-06T07:21:34Z

.github/workflows/ScreenShotTest.yml

+          path: preview-screenshots/out/failures
+
+      - name: Comment PR
+        continue-on-error: true


This may not be necessary, too.

github-actions · 2022-09-08T11:45:58Z

There are differences in Compose previews. Please check your build and download the diff artifact.
https://github.com/DroidKaigi/conference-app-2022/actions/runs/3014753123

sobaya-0141 · 2022-09-08T12:03:50Z

Commit history has been reorganized and made available for review.

takahirom · 2022-09-09T03:55:09Z

core-ui/build.gradle.kts

 plugins {
    id("droidkaigi.primitive.android")
    id("droidkaigi.primitive.android.kotlin")
    id("droidkaigi.primitive.android.compose")
    id("droidkaigi.primitive.android.hilt")
    id("droidkaigi.primitive.molecule")
    id("droidkaigi.primitive.spotless")
+    alias(libs.plugins.ksp)


Can you create "droidkaigi.primitive.android.compose.showkase"?

takahirom · 2022-09-09T03:56:07Z

preview-screenshots/build.gradle.kts

+    id("droidkaigi.primitive.molecule")
+    id("droidkaigi.primitive.spotless")
+    alias(libs.plugins.ksp)
+    alias(libs.plugins.paparazzi)


Can you create "droidkaigi.primitive.android.paparazzi"?

takahirom · 2022-09-09T03:57:25Z

settings.gradle.kts

@@ -4,7 +4,7 @@ pluginManagement {
        gradlePluginPortal()
        google()
        mavenCentral()
-//        maven("https://oss.sonatype.org/content/repositories/snapshots/")
+        maven("https://oss.sonatype.org/content/repositories/snapshots/")


If we make it a plugin, we'll be able to remove this? 👀

takahirom · 2022-09-09T03:59:03Z

@sobaya-0141 I commented on some points 🙏 Could you please take a look at the comment?

sobaya-0141 · 2022-09-11T03:01:10Z

Thank you for your review.
We will respond to it now.
Please wait for a while.

fumiya-kume · 2022-09-12T14:58:25Z

.github/workflows/ScreenShotTest.yml

+        run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties
+
+      - name: Set up JDK 11
+        uses: actions/setup-java@v1


[nit] Would you keep using v1 action? or just forget changing to v3?
I can see the v3.x.x in the action releases

I'd like to know the your thought if you have. 🙇

Yes, you are right, it should be v3.x.x.:pray:

fumiya-kume · 2022-09-12T15:06:05Z

preview-screenshots/src/test/java/io/github/droidkaigi/confsched2022/PreviewScreenshotTests.kt

+    ) {
+        NEXUS_5(DeviceConfig.NEXUS_5),
+        PIXEL_5(DeviceConfig.PIXEL_5),
+        PIXEL_C(DeviceConfig.PIXEL_C),


[nit] How about consider to adding the Pixel6 or Nexus 10 ? The Pixel6 is latest device, The Nexus 10 is a one of the tablet devices(I'm not sure we are suppressed to support fro Table devices)

oh, sorry. I never know the Pixel C is tablet device...! bit old device than my engineer life...!

fumiya-kume · 2022-09-12T15:09:38Z

preview-screenshots/src/test/java/io/github/droidkaigi/confsched2022/PreviewScreenshotTests.kt

+import com.google.testing.junit.testparameterinjector.TestParameter.TestParameterValuesProvider
+import com.google.testing.junit.testparameterinjector.TestParameterInjector
+import org.junit.Rule
+import org.junit.Test


Just for confirmation 👀 , is Paparazzi possible to working with JUnit5? 🤔 if possible, other engineer can use modern toolchain...! ✨

I didn't check this one.
I would like to get it working first.:pray:

fumiya-kume · 2022-09-12T15:10:32Z

.github/workflows/UpdateScreenshots.yml

+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-java@v1


Same: https://github.com/DroidKaigi/conference-app-2022/pull/97/files#r968528984

takahirom · 2022-09-14T00:14:24Z

I fixed the conflict in GitHub.

takahirom · 2022-09-14T00:19:27Z

@sobaya-0141 If you don't have time, we can develop this PR by recruiting contributors to this PR. What do you think?

sobaya-0141 · 2022-09-14T00:25:17Z

@takahirom
Let me do it until 10:00 today.
If I cannot complete it by then, please assign it to someone else.:bow:

sobaya-0141 · 2022-09-14T02:09:13Z

I can't seem to find the time, so let me give it up.:bow::bow::bow:

Refine preview test

takahirom · 2022-09-15T04:15:33Z

Let's merge!

sobaya-0141 added 3 commits September 2, 2022 21:10

add paparazzi & showcase

f483c93

add test module

48802bb

add preview parameter

df249fe

add ci setting

github-actions bot reviewed Sep 2, 2022

View reviewed changes

sobaya-0141 added 4 commits September 2, 2022 23:28

fixed spotless

5fd9475

fixed sdk32

94224d0

test record snapshots

d133d4c

Merge branch 'main' into add_preview_test

23ac965

# Conflicts: # gradle/libs.versions.toml

github-actions bot reviewed Sep 3, 2022

View reviewed changes

remove record snapshots

01b8392

sobaya-0141 and others added 2 commits September 4, 2022 13:09

use snapshot1.1.0

1809b9c

Just use 31

93208e4

github-actions bot reviewed Sep 5, 2022

View reviewed changes

sobaya-0141 force-pushed the add_preview_test branch from 6ef7299 to 93208e4 Compare September 5, 2022 12:45

sobaya-0141 added 2 commits September 5, 2022 21:46

add workflow

9373776

Merge branch 'main' into add_preview_test

f3248d6

# Conflicts: # feature-sessions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/Sessions.kt

sobaya-0141 marked this pull request as ready for review September 5, 2022 12:52

sobaya-0141 added 2 commits September 5, 2022 22:09

remove screenshot test in Build.yml

19bef16

Merge branch 'main' into add_preview_test

bc17d49

# Conflicts: # gradle/libs.versions.toml

hkusu reviewed Sep 6, 2022

View reviewed changes

takahirom reviewed Sep 9, 2022

View reviewed changes

takahirom added the awesome label Sep 9, 2022

takahirom mentioned this pull request Sep 10, 2022

Can you suggest any good way to post Compose preview differences in the PR? #354

Closed

fumiya-kume reviewed Sep 12, 2022

View reviewed changes

Merge branch 'main' into add_preview_test

b487928

update setup-java version

0d8f6ef

takahirom mentioned this pull request Sep 14, 2022

Refine preview test #445

Closed

aqua-ix added 4 commits September 15, 2022 05:53

Fix JDK setup error

f6debee

Fix showkase build error

8dce810

Migrate to primitive plugins

eece508

Remove unused attributes

513aaa2

aqua-ix mentioned this pull request Sep 15, 2022

Refine preview test #467

Merged

Merge pull request #467 from aqua-ix/refine-preview-test

a675e42

Refine preview test

github-actions bot temporarily deployed to deploygate-distribution September 15, 2022 02:24 Inactive

takahirom merged commit 6ec4422 into main Sep 15, 2022

takahirom deleted the add_preview_test branch September 15, 2022 04:15

	class ScreenshotShowkaseModule : ShowkaseRootModule
	class ScreenshotShowkaseModule : ShowkaseRootModule

		import io.github.droidkaigi.confsched2022.model.Contributor
		import io.github.droidkaigi.confsched2022.model.fakes

Add preview test #97

Add preview test #97

Conversation

sobaya-0141 commented Sep 2, 2022 • edited Loading

Overview (Required)

Links

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 2, 2022

Choose a reason for hiding this comment

github-actions bot Sep 3, 2022

Choose a reason for hiding this comment

sobaya-0141 commented Sep 3, 2022

takahirom commented Sep 4, 2022

github-actions bot Sep 5, 2022

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

github-actions bot commented Sep 5, 2022

sobaya-0141 commented Sep 6, 2022

github-actions bot commented Sep 6, 2022

hkusu Sep 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hkusu Sep 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 8, 2022

sobaya-0141 commented Sep 8, 2022

takahirom Sep 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

takahirom commented Sep 9, 2022

sobaya-0141 commented Sep 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fumiya-kume Sep 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

takahirom commented Sep 14, 2022

takahirom commented Sep 14, 2022

sobaya-0141 commented Sep 14, 2022

sobaya-0141 commented Sep 14, 2022

takahirom commented Sep 15, 2022

sobaya-0141 commented Sep 2, 2022 •

edited

Loading

hkusu Sep 6, 2022 •

edited

Loading

hkusu Sep 6, 2022 •

edited

Loading

takahirom Sep 9, 2022 •

edited

Loading

fumiya-kume Sep 12, 2022 •

edited

Loading