-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with ha-google-home #23
Comments
Hey, funny thing, I just found your integration yesterday and was thinking about deprecating mine in favor of your approach. Some of the differences between our components:
I am lacking the time, but wanted to upstream my work eventually and I think reviving the What are your goals with the project? Would you be willing to adjust the api layer? |
Sounds good, thanks for getting back to me 💥 Well, the ultimate goal is to put community efforts together to finally make usable sense of google-assistant enhanced home devices. Our places are packed with google home devices and we run home assistant in parallel but the two sadly doesn't work together for the past 2 years 😅 Speaking technicalities, as long as there is community need and interest to invest effort into the project - we are up for the challenge (I'm talking for myself)! 💥 As you have mentioned, there are a lot more work to be done: API extraction to a separate package (as You seem knowledgable in the area and skilled in the field - that's why we'd be happy if you'd join our small team :) Ofc, we are all volunteers and can invest only so much time and effort into the project, but it'll definitely be so much more effective to join "forces" :) As you have mentioned, one way of doing so - you could deprecate the repo in favour of |
Done. Feel free to send me an invite any time. |
Hey, @Drakulix, we just found out that you are developing very similar packages as we do at https://github.com/leikoilja/ha-google-home with a few more super talented developers.
Do you want to join and merge our repos together?
We would be much more efficient altogether with the more consistent flow of develop-test-review-release under the same project instead of various smaller similar projects.
Under the hood, we are using python glocaltokens package which main goal is to fetch and provide local authentication tokens that are needed to make API requests to google devices. Keeping it close to
glocaltokens
package will allow for both projects to grow faster with more contributors 💥Let us know what you think
The text was updated successfully, but these errors were encountered: