Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Explicitly set the display of the svg in the spin to inline #2272

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Jun 3, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes # 内部 oncall
反馈 table 的 loading icon 没有居中,排查发现是 Spin 组件的 svg 的 display 受到 tailwind 的默认设置有关系
svg 的默认 display 为 inline
tailwind 中默认设置的 svg display 为 block

Changelog

🇨🇳 Chinese

  • Style: 显式设置 Spin 下的 svg 的 display 属性为 inline,防止 tailwind 默认 svg 设置对 Spin 造成影响

🇺🇸 English

  • Style: Explicitly set the display attribute of the svg under Spin to inline to prevent the tailwind default svg setting from affecting Spin.

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YyumeiZhang YyumeiZhang requested a review from DaiQiangReal June 3, 2024 13:08
Copy link

codesandbox-ci bot commented Jun 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6198d63:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Jun 3, 2024

Passing run #2540 ↗︎

0 260 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 6198d63 into 0837b0f...
Project: semi-design Commit: 3c532d6651 ℹ️
Status: Passed Duration: 10:50 💡
Started: Jun 3, 2024 1:16 PM Ended: Jun 3, 2024 1:27 PM

Review all test suite changes for PR #2272 ↗︎

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.23%. Comparing base (0837b0f) to head (3c532d6).

Current head 3c532d6 differs from pull request most recent head 6198d63

Please upload reports for the commit 6198d63 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2272      +/-   ##
==========================================
- Coverage   88.24%   88.23%   -0.02%     
==========================================
  Files         441      441              
  Lines       26072    26072              
  Branches     6659     6659              
==========================================
- Hits        23007    23004       -3     
- Misses       3065     3068       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YyumeiZhang YyumeiZhang merged commit 304ccda into main Jun 4, 2024
11 checks passed
@YyumeiZhang YyumeiZhang deleted the style/spin-svg branch June 4, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants