Code fix for SA 1202 breaks code

[JohanLarsson]

public static class Foo
{
    private static readonly string A = string.Empty;
    public static readonly string B = A;
}

Repro ^

[sharwell]

@Noryoko @hvanbakel How would you recommend this be handled?

[hvanbakel]

@sharwell I would suggest to leave it like this to be honest. This is just a (hopefully very rare) edge case in my opinion with a public field which could've been encapsulated as a property.

[sharwell]

The code above is interesting. It's almost always a bug to have code like this, and an analyzer could certainly report cases where it occurs. Filed DotNetAnalyzers/Proposals#42.

I am concerned about the code fix behavior for the following reasons (which all add up to what looks like a pretty major problem):

1. The code fix is not expected to change behavior at all, but it can.
2. The incorrect code is not obvious to the eye. Users need to understand the order of evaluation in C#, and also in large files need to actually see both of the affected fields to see that their placement changed.
3. The change in behavior is completely silent. No warning or errors are produced with either ordering.

[JohanLarsson]

@hvanbakel pretty common in WPF, not sure you can declare a readonly dependency property without violating it.

Sample