Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory usage of tag component type #69

Closed
Doraku opened this issue Nov 16, 2019 · 1 comment
Closed

reduce memory usage of tag component type #69

Doraku opened this issue Nov 16, 2019 · 1 comment
Labels
enhancement New feature or request wontdo This will not be worked on

Comments

@Doraku
Copy link
Owner

Doraku commented Nov 16, 2019

memory usage of tag component type could be reduced to 0 by just using the ComponentFlag, that would mean those group of functions would behave the same for flag type
set flag

  • Entity.Set<>
  • Entity.SetSameAs<>
  • Entity.Enable<>

remove flag

  • Entity.Remove<>
  • Entity.Disable<>

check flag

  • Entity.Has<>
  • Entity.IsEnabled<>

Entity.Get<> would be useless (well it is already is anyway for flag types), forbidden even!

This special behavior might be worth it as we would save 3int of memory for each entity and each flag type. Still on the fence to do it or not.

@Doraku Doraku added enhancement New feature or request todo || !todo To do or not to do labels Nov 16, 2019
@Doraku Doraku mentioned this issue Nov 8, 2021
@Doraku Doraku added wontdo This will not be worked on and removed todo || !todo To do or not to do labels Nov 19, 2022
@Doraku
Copy link
Owner Author

Doraku commented Nov 19, 2022

Closing this as it won't be done on the current implementation but it is something that should come naturally if #137 actually comes to reality.

@Doraku Doraku closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontdo This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant